ZDoom

Yeah it would mean that the "clamp" function would actually have to be defined somewhere.

I could have easily done it that way - but not knowing whether or not it was available, I figured it was easier and less time consuming for me to just do it manually.

volume = clamp(volume, 0.0, 1.0);
 

Is there a different effect if you did

[code=php]
volume = clamp(volume, 0.0, 1.0);
 [/code]

instead? Just curious.

[quote="RaveYard"]But still, I really don't see any checks in the source code. Not in [color=red][u]A_SoundVolume[/u][/color] or S_ChangeSoundVolume or OpenALSoundRenderer::ChannelVolume. :([/quote]

I absolutely cannot stress enough the utter importance of specific information like this in bug reports! I figured that the modding functions might be the case but if I had the actual function names like this, I could have gone through it a whole lot quicker. If I had a sample of DECORATE code already prepared that abuses this function - it would have gone yet even quicker than that.

Please include stuff like this in your reports in the future.

This problem has been around since forever, BTW - even before ZScript existed. I always ran into this when doing sound stuff through ACS if I incorrectly calculated the volume to play.

Yeah, this definitely needs checking.

	double soundVolume;
	double soundFadeSpeed;

	soundVolume -= soundFadeSpeed;
	A_SoundVolume(CHAN_7, soundVolume);

Actually, I'm using A_SoundVolume where the volume parameter is from a variable.

[code]
double soundVolume;
double soundFadeSpeed;
[/code]
[code]
soundVolume -= soundFadeSpeed;
A_SoundVolume(CHAN_7, soundVolume);
[/code]
But still, I really don't see any checks in the source code. Not in A_SoundVolume or S_ChangeSoundVolume or OpenALSoundRenderer::ChannelVolume. :(

What are you doing to change it? There's already max checkers in place.

S_ChangeSoundVolume has no sanity check for volume specified, thus having negative values leads to OpenAL errors which left me confused for few days.

Some sort of warning or "max(volume, 0)", would be really neat. :wink: