ZDoom

OK, cleaned up [b]FStateDefinitions[/b] in [url=https://github.com/coelckers/gzdoom/commit/274951839aa0d7fdb74b119fa83ff28215a5ea3b]2749518[/url] and left [b]GLPortal[/b] as is.

It's not used right now - but it may get used eventually. I'm not sure. The first one in ResolveGotoLabel can be safely changed, though

So now [b]doquery[/b] can be remove too, right?

The first one looks like a leftover from early development when states were not accessed by labels but only by the explicit state pointers in AActor.
The second one was used, but not correctly, so when I changed that code I played it safe.

src/p_states.cpp: In member function ‘FState* FStateDefinitions::ResolveGotoLabel(AActor*, PClassActor*, char*)’:
src/p_states.cpp:724:54: warning: parameter ‘actor’ set but not used [-Wunused-but-set-parameter]
 FState *FStateDefinitions::ResolveGotoLabel (AActor *actor, PClassActor *mytype, char *name)
                                                      ^

src/gl/scene/gl_portal.cpp: In member function ‘bool GLPortal::Start(bool, bool)’:
src/gl/scene/gl_portal.cpp:178:44: warning: parameter ‘doquery’ set but not used [-Wunused-but-set-parameter]
 bool GLPortal::Start(bool usestencil, bool doquery)
                                            ^

I have a question about two compilation warnings [url=https://travis-ci.org/coelckers/gzdoom/jobs/297477647]reported by GCC 4.9[/url] related to unused function parameters.

[url=https://travis-ci.org/coelckers/gzdoom/jobs/297477647#L1402]The first parameter[/url] seems to be redundant as I found no use for it inside the mentioned function and so can safely removed:
[code]src/p_states.cpp: In member function ‘FState* FStateDefinitions::ResolveGotoLabel(AActor*, PClassActor*, char*)’:
src/p_states.cpp:724:54: warning: parameter ‘actor’ set but not used [-Wunused-but-set-parameter]
FState *FStateDefinitions::ResolveGotoLabel (AActor *actor, PClassActor *mytype, char *name)
^[/code]
[url=https://travis-ci.org/coelckers/gzdoom/jobs/297477647#L1346]The second one[/url] is more suspicious. From my point of view [b]doquery[/b] should be checked somewhere to decide on occlusion query usage:
[code]src/gl/scene/gl_portal.cpp: In member function ‘bool GLPortal::Start(bool, bool)’:
src/gl/scene/gl_portal.cpp:178:44: warning: parameter ‘doquery’ set but not used [-Wunused-but-set-parameter]
bool GLPortal::Start(bool usestencil, bool doquery)
^[/code]
While the former is pretty old (I don't expect Randi will come and tell us about it) the latter is relatively new and I hope Graf can give some details about it.