I have a question about two compilation warnings
reported by GCC 4.9 related to unused function parameters.
The first parameter seems to be redundant as I found no use for it inside the mentioned function and so can safely removed:
Code: Select all
src/p_states.cpp: In member function ‘FState* FStateDefinitions::ResolveGotoLabel(AActor*, PClassActor*, char*)’:
src/p_states.cpp:724:54: warning: parameter ‘actor’ set but not used [-Wunused-but-set-parameter]
FState *FStateDefinitions::ResolveGotoLabel (AActor *actor, PClassActor *mytype, char *name)
^
The second one is more suspicious. From my point of view
doquery should be checked somewhere to decide on occlusion query usage:
Code: Select all
src/gl/scene/gl_portal.cpp: In member function ‘bool GLPortal::Start(bool, bool)’:
src/gl/scene/gl_portal.cpp:178:44: warning: parameter ‘doquery’ set but not used [-Wunused-but-set-parameter]
bool GLPortal::Start(bool usestencil, bool doquery)
^
While the former is pretty old (I don't expect Randi will come and tell us about it) the latter is relatively new and I hope Graf can give some details about it.
I have a question about two compilation warnings [url=https://travis-ci.org/coelckers/gzdoom/jobs/297477647]reported by GCC 4.9[/url] related to unused function parameters.
[url=https://travis-ci.org/coelckers/gzdoom/jobs/297477647#L1402]The first parameter[/url] seems to be redundant as I found no use for it inside the mentioned function and so can safely removed:
[code]src/p_states.cpp: In member function ‘FState* FStateDefinitions::ResolveGotoLabel(AActor*, PClassActor*, char*)’:
src/p_states.cpp:724:54: warning: parameter ‘actor’ set but not used [-Wunused-but-set-parameter]
FState *FStateDefinitions::ResolveGotoLabel (AActor *actor, PClassActor *mytype, char *name)
^[/code]
[url=https://travis-ci.org/coelckers/gzdoom/jobs/297477647#L1346]The second one[/url] is more suspicious. From my point of view [b]doquery[/b] should be checked somewhere to decide on occlusion query usage:
[code]src/gl/scene/gl_portal.cpp: In member function ‘bool GLPortal::Start(bool, bool)’:
src/gl/scene/gl_portal.cpp:178:44: warning: parameter ‘doquery’ set but not used [-Wunused-but-set-parameter]
bool GLPortal::Start(bool usestencil, bool doquery)
^[/code]
While the former is pretty old (I don't expect Randi will come and tell us about it) the latter is relatively new and I hope Graf can give some details about it.