Git commit broke build

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.

Post a reply

Smilies
:D :) :( :o :shock: :? 8-) :lol: :x :P :oops: :cry: :evil: :twisted: :roll: :wink: :geek: :ugeek: :!: :?: :idea: :arrow: :| :mrgreen: :3: :wub: >:( :blergh:
View more smilies
BBCode is OFF
Smilies are ON
Topic review
   

Expand view Topic review: Git commit broke build

Re: Git commit broke build

by _mental_ » Wed Nov 01, 2017 6:53 am

I believe this was fixed in b871b18.

Re: Git commit broke build

by Guest » Sun Sep 17, 2017 12:18 am

Not all unfortunately (wordexp is considered harmful and buggy to be worth implemented for some), ok I understand the reasoning a bit better though.

Re: Git commit broke build

by Chris » Sat Sep 16, 2017 10:21 pm

Phyllis Hirringhood wrote:This commit https://github.com/coelckers/gzdoom/com ... 1d7a118044 unfortunately broke build on BSD (e.g. because of wordexp), was the previous feature wrong ?
Prior to that patch, "quoted arguments" weren't honored. Unlike the Windows build they would get treated as two separate arguments, '"quoted' and 'arguments"', which breaks anything that needs a space (for example if you wanted to set timidity_extargs='-c "/path/to/soundfonts/my soundfont.cfg"').

Does BSD not have wordexp? Both it and glob (which has been used to find the executable) are listed as being POSIX.1-2001, POSIX.1-2008.

Git commit broke build

by Guest » Sat Sep 16, 2017 2:41 pm

Hello.

This commit https://github.com/coelckers/gzdoom/com ... 1d7a118044 unfortunately broke build on BSD (e.g. because of wordexp), was the previous feature wrong ?

Thanks for the good work otherwise.
Kindest regards.

Top