Regarding pull requests for ACS features

Forum rules
Please see Code submission guidelines

GZDoom Status:
Image

Legacy Status:
Image Image

QZDoom Status:
Image

Post a reply

Smilies
:D :) :( :o :shock: :? 8-) :lol: :x :P :oops: :cry: :evil: :twisted: :roll: :wink: :geek: :ugeek: :!: :?: :idea: :arrow: :| :mrgreen: :3: :wub: >:( :blergh:
View more smilies

BBCode is ON
[img] is OFF
[url] is ON
Smilies are ON

Topic review
   

Expand view Topic review: Regarding pull requests for ACS features

Re: Regarding pull requests for ACS features

by Graf Zahl » Mon Mar 31, 2014 10:46 am

Ok, but please mention such a thing next time, just in case. I thought it required an extension to the function table.

Re: Regarding pull requests for ACS features

by Nightfall » Mon Mar 31, 2014 8:36 am

Hm? My change doesn't need any changes to ACC since it's a change on how a parameter is interpreted.

Regarding pull requests for ACS features

by Graf Zahl » Mon Mar 31, 2014 7:58 am

There have been several pull requests for ACS extensions recently, and they all share the same problem: They only contain the changes needed on ZDoom's side, but nothing on ACC's side.

Please note that I will not add any such request unless it is either accompanied by a corresponding request for the ACC repo or some info what to add - even if it's supposedly trivial and obvious there's still stuff that can be missed and render the submitted feature inoperable.

Top