Bouncing projectiles don't hurt when hitting top/bottom

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.

Post a reply

Smilies
:D :) :( :o :shock: :? 8-) :lol: :x :P :oops: :cry: :evil: :twisted: :roll: :wink: :geek: :ugeek: :!: :?: :idea: :arrow: :| :mrgreen: :3: :wub: >:( :blergh:
View more smilies

BBCode is OFF
Smilies are ON

Topic review
   

Expand view Topic review: Bouncing projectiles don't hurt when hitting top/bottom

Re: Bouncing projectiles don't hurt when hitting top/bottom

by SanyaWaffles » Thu Apr 30, 2020 1:13 am

I saw that this got merged. Should this be marked as fixed now?

Re: Bouncing projectiles don't hurt when hitting top/bottom

by Major Cooke » Sun Apr 12, 2020 7:50 pm

I'm tempted to move this to code submissions since we now have a fix for it. That way it won't get lost.

Re: Bouncing projectiles don't hurt when hitting top/bottom

by SanyaWaffles » Sun Apr 12, 2020 7:08 pm

I'm hoping this will be merged before next release then.

Re: Bouncing projectiles don't hurt when hitting top/bottom

by Marisa the Magician » Sun Apr 12, 2020 4:14 pm

Tested on my end, confirmed that it all works as expected now, without side effects.

Re: Bouncing projectiles don't hurt when hitting top/bottom

by drfrag » Sun Apr 12, 2020 9:07 am

I've merged this and uploaded a test build, for me the example is working. Some things need testing and while i was at it...
https://devbuilds.drdteam.org/lzdoom/lz ... c45eab5.7z
https://github.com/drfrag666/gzdoom/commits/master

Re: Bouncing projectiles don't hurt when hitting top/bottom

by SanyaWaffles » Thu Apr 09, 2020 8:31 pm

So I tested it out, but I had to test it using the artifact from Travis-CL... it seems to fix the problem, bouncing grenades are working more reliably now.

Re: Bouncing projectiles don't hurt when hitting top/bottom

by Major Cooke » Wed Apr 08, 2020 9:09 am

I've merged it. It'll become available whenever the next build is scheduled, which is usually daily. The release times can be seen here.

Don't be, I usually keep it up to date whenever it's needed. I have contributor access to the repository so I can keep it up to date.

Re: Bouncing projectiles don't hurt when hitting top/bottom

by SanyaWaffles » Tue Apr 07, 2020 11:30 pm

If you do Cooke, when can you expect a build? This has been messing with one of my projects and I very much wish to test it out. I normally don't use qzdoom so I have no idea how frequently it gets updated. I also worry about it being out of date with recent GZDoom features.

Re: Bouncing projectiles don't hurt when hitting top/bottom

by Major Cooke » Tue Apr 07, 2020 6:17 pm

I'm going to merge in this PR into QZDoom if no one has any qualms about it, since I very much am finding myself in need of it.

Re: Bouncing projectiles don't hurt when hitting top/bottom

by Cacodemon345 » Fri Apr 03, 2020 11:55 am

Now that I look into the source code, P_XYMovement function calls P_BounceActor with "ontop = false" in two places. The only function where I found that function called with "ontop = true" is the main Actor Tick function.

When I used a breakpoint in line 1483 of p_map, I found that the code in PIT_CheckThing only reaches there with the non-bouncing projectile, it does not even reach there with the bouncing project when I used Marisa's bug reproduction example. When that happens, P_BounceActor is called with "ontop = true".

This means that there HAS to be some place in the code which uses the Actor Bounce flag to change something that causes that portion of PIT_CheckThing to be unreachable.

Edit: further testing reveals a oddity: CanCollideWith() is called more than once for the non-bouncing projectile when it does not actually hit, but is only called once when the bouncing projectile actually hits the monster.

Re: Bouncing projectiles don't hurt when hitting top/bottom

by Cacodemon345 » Fri Apr 03, 2020 2:46 am

All I fixed is the missile not entering bouncing state when hit from top. I don't really believe it could cause any possible side-effects.

Re: Bouncing projectiles don't hurt when hitting top/bottom

by Major Cooke » Wed Mar 18, 2020 4:41 pm

It might be worth going back to Cacodemon345's commits and finding out what he fixed.

Re: Bouncing projectiles don't hurt when hitting top/bottom

by SanyaWaffles » Wed Mar 18, 2020 2:46 pm

This is becoming extremely noticeable at times in my project. You can hit an enemy square on the top and there's no damage or whatever when using bouncing bombs. It's an extremely aggravating bug and there's no way to fix.

Re: Bouncing projectiles don't hurt when hitting top/bottom

by Graf Zahl » Tue Mar 10, 2020 7:36 am

That's the problem, I don't really know how to do it without causing unintended side effects.

Re: Bouncing projectiles don't hurt when hitting top/bottom

by Major Cooke » Tue Mar 10, 2020 7:30 am

If neither of those are fitting solutions, what is?

Top