ZDoom

I know, but the last time a fix was attempted it didn't work out. The report needs to remain open but that alone is no reason to leave the non-functional code in.

But this won't prevent usage of the same broken code in mods. Fixing core script without prohibiting re-return of multiple values seems a bit fragile.

This one's more descriptiv, though. However, since I currently have no idea how to handle this, I changed the problem code to use the above workaround.

This was already reported [url=https://forum.zdoom.org/viewtopic.php?t=62813]here[/url].

if (player.PendingWeapon != WP_NOCHANGE)
{
	bool found;
	int slot;
	int index;
	[found, slot, index] = player.weapons.LocateWeapon(player.PendingWeapon.GetClass());
	return found, slot, index;
}

if (player.PendingWeapon != WP_NOCHANGE)
{
	return player.weapons.LocateWeapon(player.PendingWeapon.GetClass());
}

It looks like the ZScript VM cannot recursively return multiple values from a function that returns multiple values. For example, switching to the next or previous weapon while there is a pending weapon does not work as expected. The real issue seems to be in zscript/shared/player.txt on line 1927.

Apparently, this works properly:
[code]
if (player.PendingWeapon != WP_NOCHANGE)
{
bool found;
int slot;
int index;
[found, slot, index] = player.weapons.LocateWeapon(player.PendingWeapon.GetClass());
return found, slot, index;
}
[/code]

But this code, which is currently being used, does not:
[code]
if (player.PendingWeapon != WP_NOCHANGE)
{
return player.weapons.LocateWeapon(player.PendingWeapon.GetClass());
}
[/code]

Note that I am NOT using the JIT compiler, as I don't quite trust it to be stable enough for everyday use yet.