Rail Puff Support for Floors and Ceilings

Post a reply

Smilies
:D :) :( :o :shock: :? 8-) :lol: :x :P :oops: :cry: :evil: :twisted: :roll: :wink: :geek: :ugeek: :!: :?: :idea: :arrow: :| :mrgreen: :3: :wub: >:( :blergh:
View more smilies
BBCode is OFF
Smilies are ON
Topic review
   

Expand view Topic review: Rail Puff Support for Floors and Ceilings

Re: Rail Puff Support for Floors and Ceilings

by Major Cooke » Sat Jan 16, 2016 4:59 pm

Okay.

Re: Rail Puff Support for Floors and Ceilings

by Graf Zahl » Sat Jan 16, 2016 2:43 pm

Skies should be off by default, unless the SKYEXPLODE flag is specified. No more needless options.

Re: Rail Puff Support for Floors and Ceilings

by Major Cooke » Sat Jan 16, 2016 2:31 pm

Better yet, a flag to allow the +ALWAYSPUFF flag. Not just skies.

Re: Rail Puff Support for Floors and Ceilings

by Graf Zahl » Sat Jan 16, 2016 2:16 pm

How can this affect your traces spawned with P_LineAttack, when the change is in P_RailAttack?

That said, it should definitely have a sky check added.

Re: Rail Puff Support for Floors and Ceilings

by Nash » Sat Jan 16, 2016 2:05 pm

This broke my line traces (spawned with LineAttack) that rely on the puffs automatically disappearing when it hits sky ceilings and floors (and also required +ALWAYSPUFF so that they collide with live actors). Please revert or add an option for your new behavior.

Rail Puff Support for Floors and Ceilings

by Major Cooke » Thu Jan 14, 2016 11:24 am

Pull Request

A simple change, this adds the ability for puffs to spawn on floors and ceilings if the puffs have ALWAYSPUFF specified. In a way, this is technically a bugfix and a feature.

I went this route and added support for the flag because it was either this, or expanding bullet attack functionalities with the abilities to provide offsets from the shooter which no one can really see without a beam. This I feel was much simpler.

Top