drfrag wrote:AFAIK ZScript and engine versions don't need to match. Besides i think you put them backwards.
This is correct.
Major Cooke wrote:ZScript and GZDoom engine versions have been set to match for a while now.
Irrelevant. It's talking about the ZScript version, not the GZDoom version.
This PR basically creates an inherent misnomer, even if the ZScript version happened to match the GZDoom version all this time. It does not take into account child ports, which do not follow GZDoom's versioning scheme.
So yeah - this is not mergeable as-is.
Please rephrase it accordingly.
[quote="drfrag"]AFAIK ZScript and engine versions don't need to match. Besides i think you put them backwards.[/quote]
This is correct.
[quote="Major Cooke"]ZScript and GZDoom engine versions have been set to match for a while now.[/quote]
Irrelevant. It's talking about the ZScript version, not the GZDoom version.
This PR basically creates an inherent misnomer, even if the ZScript version happened to match the GZDoom version all this time. It does not take into account child ports, which do not follow GZDoom's versioning scheme.
So yeah - this is not mergeable as-is.
Please rephrase it accordingly.