Version Mismatch text change

Post a reply

Smilies
:D :) :( :o :shock: :? 8-) :lol: :x :P :oops: :cry: :evil: :twisted: :roll: :wink: :geek: :ugeek: :!: :?: :idea: :arrow: :| :mrgreen: :3: :wub: >:( :blergh:
View more smilies
BBCode is OFF
Smilies are ON
Topic review
   

Expand view Topic review: Version Mismatch text change

Re: Version Mismatch text change

by Major Cooke » Sun Jun 30, 2019 8:19 pm

That's plenty good for me.

Re: Version Mismatch text change

by Rachael » Sun Jun 30, 2019 8:15 pm

I added this but with major changes in this commit.

Re: Version Mismatch text change

by Rachael » Sun Jun 30, 2019 7:23 pm

drfrag wrote:AFAIK ZScript and engine versions don't need to match. Besides i think you put them backwards.
This is correct.
Major Cooke wrote:ZScript and GZDoom engine versions have been set to match for a while now.
Irrelevant. It's talking about the ZScript version, not the GZDoom version.

This PR basically creates an inherent misnomer, even if the ZScript version happened to match the GZDoom version all this time. It does not take into account child ports, which do not follow GZDoom's versioning scheme.

So yeah - this is not mergeable as-is.

Please rephrase it accordingly.

Re: Version Mismatch text change

by Major Cooke » Sun Jun 30, 2019 5:32 pm

Sadly I didn't finish the edit until after you did. At any rate it's all fixed.

Re: Version Mismatch text change

by phantombeta » Sun Jun 30, 2019 5:26 pm

Major Cooke wrote:ZScript and GZDoom engine versions have been set to match for a while now. Also amusingly, it's been backwards for a while it seems.
That's not backwards. The mod expects 4.0.0 or higher, while the version of GZDoom is 3.5.1. Your PR, meanwhile, is actually backwards. It'd print

Code: Select all

Version mismatch. GZDoom 4.0.0 is incompatible with at least one file. Version 3.5.1 or later is required.
Which is obviously wrong.

Re: Version Mismatch text change

by Major Cooke » Sun Jun 30, 2019 5:15 pm

ZScript and GZDoom engine versions have been set to match for a while now. Also fixed.

Re: Version Mismatch text change

by drfrag » Sun Jun 30, 2019 12:59 pm

AFAIK ZScript and engine versions don't need to match. Besides i think you put them backwards.

Version Mismatch text change

by Major Cooke » Sun Jun 30, 2019 12:34 pm

Pull Request

Because I keep getting the same question over and over again with my mods:
Many people wrote:What's this <x> expected and only <y> supported? I have <x> though!
I know that won't change anything in the short term, but as time goes on and new versions come out, that should hopefully fade off...

Top