ZDoom

Thanks for merging. This can be closed.

Added PR and a test file. Zombiemen are replaced via CheckReplacements and without the use of 'replaces' keyword, which is attributed by CheckReplacee.

struct ReplacedEvent native version("2.4")
{
	native Class<Actor> Replacee;
	native readonly Class<Actor> Replacement;
	native bool IsFinal;
}

override void CheckReplacee(ReplacedEvent e)
{
	Class<Actor> rep = e.Replacement;
	
	static const Class<Actor> mons[] =
	{
		'MiniMind',
		'Demolisher',
		'Sentient'
	};
	
	for (int i = 0; i < mons.Size(); i++)
	{
		if (rep == mons[i])
		{
			e.Replacee = 'SpiderMastermind'; 
			e.IsFinal = true; 
			return;
		}
	}
}

[url=https://github.com/coelckers/gzdoom/pull/723]Pull Request[/url]

There's one small pitfall when using CheckReplacement to replace actors; there's no way to get the actual replacee with it.

So what I suggest is CheckReplacee using a Replace[b][u]d[/u][/b]Event struct:

[code]struct ReplacedEvent native version("2.4")
{
native Class<Actor> Replacee;
native readonly Class<Actor> Replacement;
native bool IsFinal;
}[/code]

Then it would be down to the modder to indicate under what class it belongs. This will especially be useful for mods that are made to combine and/or be friendly with other mods/addons.

[code]override void CheckReplacee(ReplacedEvent e)
{
Class<Actor> rep = e.Replacement;

static const Class<Actor> mons[] =
{
'MiniMind',
'Demolisher',
'Sentient'
};

for (int i = 0; i < mons.Size(); i++)
{
if (rep == mons[i])
{
e.Replacee = 'SpiderMastermind';
e.IsFinal = true;
return;
}
}
}[/code]

Sure, this might be a bit of book keeping, but right now:
[list][*]A_BossDeath is partly broken (but can be fixed by using a randomspawner instead)
[*]CheckReplacee, if used by mods that have little to no 'replaces' being used, is equally just as useless.[/list]

Having the CheckReplacee event function would solve both with a little book keeping by modders. In fact, it would be easy for modders to create an object with two arrays inside that keeps track of every new entity spawned, filled in whenever CheckReplacement is called.