by Major Cooke » Wed Dec 12, 2018 9:54 pm
Pull Request
Finally. The complete and total separation of all state management in that god-forsaken piece of code is done.
DamageMobj now returns -1 for all cancelled damage, which means no state changes happen. 0 for normalcy, where pain flags can still apply.
Bonus: Modders have
TriggerPainChance(Name mod, bool forcedPain) at their disposal now.
Graf: I have not deprecated ALLOW/CAUSEPAIN flags yet. With the code sorted out at last, and the flags still work, I think I found a nice balance where they won't be intrusive anymore without the need to remove their functionality.
If you still wish to see them removed, I can do that, but please consider a second look before deciding. It was the big elephant in the room, now it's the size of a cricket.
Anything else you want changed?
[url=https://github.com/coelckers/gzdoom/pull/664]Pull Request[/url]
Finally. The complete and total separation of all state management in that god-forsaken piece of code is done.
DamageMobj now returns -1 for all cancelled damage, which means no state changes happen. 0 for normalcy, where pain flags can still apply.
Bonus: Modders have [b]TriggerPainChance(Name mod, bool forcedPain)[/b] at their disposal now.
Graf: I have not deprecated ALLOW/CAUSEPAIN flags yet. With the code sorted out at last, and the flags still work, I think I found a nice balance where they won't be intrusive anymore without the need to remove their functionality.
If you still wish to see them removed, I can do that, but please consider a second look before deciding. It was the big elephant in the room, now it's the size of a cricket.
Anything else you want changed?