by Altazimuth » Sat Oct 27, 2018 2:02 pm
Posting this here for visibility, as I'm uncertain how much attention is paid to the ZDBSP repo (or if rheit/zdbsp is where PRs are supposed to be sent nowadays).
printz wrote:Because of a forgotten line of code which wasn't deleted, extended segs get the wrong "side" information when a linedef has the same sidedef repeated on both parts of the 2-sided wall. The line was safe to delete because clearly the side was just set inside both branches of the if block.
Pull request can be found here:
https://github.com/rheit/zdbsp/pull/6
The fix is extremely small, just removal of lines 524 (blank line) and 525 of nodebuild_extract.cpp, which is:
Code: Select all
newseg.side = Level.Lines[org->linedef].sidenum[1] == org->sidedef ? 1 : 0;
Posting this here for visibility, as I'm uncertain how much attention is paid to the ZDBSP repo (or if rheit/zdbsp is where PRs are supposed to be sent nowadays).
[quote="printz"]Because of a forgotten line of code which wasn't deleted, extended segs get the wrong "side" information when a linedef has the same sidedef repeated on both parts of the 2-sided wall. The line was safe to delete because clearly the side was just set inside both branches of the if block.
[/quote]
Pull request can be found here: https://github.com/rheit/zdbsp/pull/6
The fix is extremely small, just removal of lines 524 (blank line) and 525 of nodebuild_extract.cpp, which is:
[code]newseg.side = Level.Lines[org->linedef].sidenum[1] == org->sidedef ? 1 : 0;[/code]