Hide "invalid sound position/velocity" messages

Post a reply

Smilies
:D :) :( :o :shock: :? 8-) :lol: :x :P :oops: :cry: :evil: :twisted: :roll: :wink: :geek: :ugeek: :!: :?: :idea: :arrow: :| :mrgreen: :3: :wub: >:( :blergh:
View more smilies

BBCode is OFF
Smilies are ON

Topic review
   

Expand view Topic review: Hide "invalid sound position/velocity" messages

Re: Hide "invalid sound position/velocity" messages

by Graf Zahl » Tue Jan 08, 2019 9:03 am

Yes, but PrBoom+ just overflows. I think we have to cap the movement to something reasonable if this happens.

Re: Hide "invalid sound position/velocity" messages

by Player701 » Tue Jan 08, 2019 8:55 am

This:
Player701 wrote:It appears that the floor of sector 195, which is triggered to lower when the switch is pressed, doesn't stop where it has to and continues lowering towards negative infinity.
The sector in question is quite unusual in structure. It consists of 4 unconnected linedefs and effectively has an area of 0. All of these linedefs are self-referencing (both on front and back sides). This sector is triggered by a switch with an "S1 Floor Lower to 8 above Highest Floor" special, and I guess the problem lies in the inability to find this "highest floor" because sector 195 doesn't reference any other sectors. This behavior is not unique to GZDoom, and has been found to also occur in PrBoom-Plus.

Re: Hide "invalid sound position/velocity" messages

by Graf Zahl » Tue Jan 08, 2019 8:40 am

I wonder what the real problem with that map is...

Re: Hide "invalid sound position/velocity" messages

by Player701 » Tue Jan 08, 2019 8:35 am

Now it's going to take about 2 hours for the messages to start spamming in Hadephobia MAP19, unless something bad happens before that due to the sector's floor level reaching -1M. Not sure if there is a limit on that... but 2 hours should probably be enough to finish the map before getting any of those warnings.

Re: Hide "invalid sound position/velocity" messages

by _mental_ » Tue Jan 08, 2019 8:21 am

Increased a range +/- 1M in df2893e.

Re: Hide "invalid sound position/velocity" messages

by Graf Zahl » Tue Jan 08, 2019 1:23 am

I think the value range should at least be expanded. But if some truly outlandish numbers get through here they should still be reported. Something like 40000 may just be a quirk with the game physics, but something like, say 1'000'000 normally is a sign of an error.

Re: Hide "invalid sound position/velocity" messages

by Chris » Mon Jan 07, 2019 6:01 pm

_mental_ wrote:Graf, are you OK with checking for infinite values only to output this message? I'm really tired of it, but making it optional is equal to making it useless IMHO.
IIRC, the message was originally added because of errant NaNs being generated in a mod, so at the very least it should be non-finite values.

Re: Hide "invalid sound position/velocity" messages

by Matt » Mon Jan 07, 2019 10:48 am

I remember asking a couple months back if a certain troublesome thing could be made to be subject to ZScript versioning and it was considered impossible or at least impractical to the point of impossibility, was it this?

Re: Hide "invalid sound position/velocity" messages

by wildweasel » Mon Jan 07, 2019 10:22 am

XLightningStormL wrote:Fix your mod then, instead of asking the developers to fix it for you with a bunch of pointless code. :P
"Fix your mod" isn't necessarily a solution when "your mod" is somebody else's mod from years ago that worked fine until recently. (Especially if, in the case of a handful of mods I know, their licenses restrict people from releasing modified/fixed versions.)

Re: Hide "invalid sound position/velocity" messages

by Rachael » Mon Jan 07, 2019 5:03 am

Wouldn't it be better to possibly do a compatibility fix on the offending object so that it cannot fall below Z -32768.00?

Re: Hide "invalid sound position/velocity" messages

by XLightningStormL » Mon Jan 07, 2019 5:01 am

Fix your mod then, instead of asking the developers to fix it for you with a bunch of pointless code. :P

Re: Hide "invalid sound position/velocity" messages

by _mental_ » Mon Jan 07, 2019 3:38 am

Graf, are you OK with checking for infinite values only to output this message? I'm really tired of it, but making it optional is equal to making it useless IMHO.

Re: Hide "invalid sound position/velocity" messages

by Enjay » Sun Jan 06, 2019 3:05 pm

FWiW, it took just shy of 4 minutes after pressing the switch for the messages to start spamming, but when they did, it was constant.


Just a little sample, the full log file by the time I quit breaks the forum character limit:

Code: Select all

Invalid sound position (1984.000000, 2184.000000, -32772.000000)
Invalid sound position (1984.000000, 2184.000000, -32776.000000)
Invalid sound position (1984.000000, 2184.000000, -32780.000000)
Invalid sound position (1984.000000, 2184.000000, -32784.000000)
Invalid sound position (1984.000000, 2184.000000, -32788.000000)
Invalid sound position (1984.000000, 2184.000000, -32792.000000)
Invalid sound position (1984.000000, 2184.000000, -32796.000000)
Invalid sound position (2002.150879, 2184.000000, -32800.000000)
Invalid sound position (2022.977661, 2184.000000, -32804.000000)
Invalid sound position (2043.691284, 2184.000000, -32808.000000)
Invalid sound position (2062.796387, 2184.000000, -32812.000000)
Invalid sound position (2080.443604, 2184.000000, -32816.000000)
Invalid sound position (2096.770020, 2184.000000, -32820.000000)
Invalid sound position (2111.899170, 2184.000000, -32824.000000)
Invalid sound position (2112.000000, 2184.000000, -32828.000000)
Invalid sound position (2112.000000, 2184.000000, -32832.000000)
Invalid sound position (2112.000000, 2184.000000, -32836.000000)
Invalid sound position (2112.000000, 2184.000000, -32840.000000)
Invalid sound position (2112.000000, 2184.000000, -32844.000000)
Invalid sound position (2112.000000, 2184.000000, -32848.000000)
Invalid sound position (2112.000000, 2184.000000, -32852.000000)
Invalid sound position (2112.000000, 2184.000000, -32856.000000)
Invalid sound position (2112.000000, 2184.000000, -32860.000000)
Invalid sound position (2112.000000, 2184.000000, -32864.000000)
Invalid sound position (2112.000000, 2184.000000, -32868.000000)
Invalid sound position (2112.000000, 2184.000000, -32872.000000)
Invalid sound position (2112.000000, 2184.000000, -32876.000000)
Invalid sound position (2112.000000, 2184.000000, -32880.000000)
Invalid sound position (2112.000000, 2184.000000, -32884.000000)
Invalid sound position (2112.000000, 2184.000000, -32888.000000)
Invalid sound position (2112.000000, 2184.000000, -32892.000000)
Invalid sound position (2112.000000, 2184.000000, -32896.000000)
Invalid sound position (2112.000000, 2184.000000, -32900.000000)
Invalid sound position (2112.000000, 2184.000000, -32904.000000)
Invalid sound position (2112.000000, 2184.000000, -32908.000000)
Invalid sound position (2112.000000, 2184.000000, -32912.000000)
Invalid sound position (2112.000000, 2184.000000, -32916.000000)
Invalid sound position (2112.000000, 2184.000000, -32920.000000)
Invalid sound position (2112.000000, 2184.000000, -32924.000000)
Invalid sound position (2112.000000, 2184.000000, -32928.000000)
Invalid sound position (2112.000000, 2184.000000, -32932.000000)
Invalid sound position (2112.000000, 2184.000000, -32936.000000)
Invalid sound position (2112.000000, 2184.000000, -32940.000000)
Invalid sound position (2112.000000, 2184.000000, -32944.000000)
Invalid sound position (2112.000000, 2184.000000, -32948.000000)
Invalid sound position (2112.000000, 2184.000000, -32952.000000)
Invalid sound position (2112.000000, 2184.000000, -32956.000000)
Invalid sound position (2112.000000, 2184.000000, -32960.000000)
Invalid sound position (2112.000000, 2184.000000, -32964.000000)
Invalid sound position (2112.000000, 2184.000000, -32968.000000)
Invalid sound position (2112.000000, 2184.000000, -32972.000000)
Invalid sound position (2112.000000, 2184.000000, -32976.000000)
Invalid sound position (2112.000000, 2184.000000, -32980.000000)
Invalid sound position (2112.000000, 2184.000000, -32984.000000)
Invalid sound position (2112.000000, 2184.000000, -32988.000000)
Invalid sound position (2112.000000, 2184.000000, -32992.000000)
Invalid sound position (2112.000000, 2184.000000, -32996.000000)
Invalid sound position (2112.000000, 2184.000000, -33000.000000)
Invalid sound position (2112.000000, 2184.000000, -33004.000000)
Invalid sound position (2112.000000, 2184.000000, -33008.000000)
Invalid sound position (2112.000000, 2184.000000, -33012.000000)
Invalid sound position (2112.000000, 2184.000000, -33016.000000)
Invalid sound position (2112.000000, 2184.000000, -33020.000000)
Invalid sound position (2112.000000, 2184.000000, -33024.000000)
Invalid sound position (2112.000000, 2184.000000, -33028.000000)
Invalid sound position (2112.000000, 2184.000000, -33032.000000)
Invalid sound position (2112.000000, 2184.000000, -33036.000000)
Invalid sound position (2112.000000, 2184.000000, -33040.000000)
Invalid sound position (2112.000000, 2184.000000, -33044.000000)
Invalid sound position (2112.000000, 2184.000000, -33048.000000)
Invalid sound position (2112.000000, 2184.000000, -33052.000000)
Invalid sound position (2112.000000, 2184.000000, -33056.000000)
Invalid sound position (2112.000000, 2184.000000, -33060.000000)

Re: Hide "invalid sound position/velocity" messages

by Player701 » Sun Jan 06, 2019 2:45 pm

Eh, I'm not sure if it's worth making a bug report for this because PrBoom-Plus seems to work the same way, but I've found a map which makes GZDoom produce a lot of "invalid sound position" messages after pressing a certain switch. This happens on Hadephobia MAP19. To reproduce, use the following command-line parameters:

Code: Select all

gzdoom.exe -file h_phobia.wad -nomonsters -warp 19 +"warp 1664 784"
Turn around and press the switch. In a few minutes, the "invalid sound position" message spam will start. It appears that the floor of sector 195, which is triggered to lower when the switch is pressed, doesn't stop where it has to and continues lowering towards negative infinity. Once the floor height passes a certain threshold, it triggers these warnings. I haven't got any crashes from this behavior so far, but this message spam kind of interferes with the gameplay. :?

Re: Hide "invalid sound position/velocity" messages

by _mental_ » Tue Nov 06, 2018 12:21 am

If I knew that this warning will cause such attention, I would add reporting for invalid values only and keep out-of-bounds position/velocity as is.

Top