ZDoom

Wow... thanks.

Mark this a 'yes' now.

I'll be using that until it's mainlined, thank you.

[url=https://github.com/coelckers/gzdoom/tree/zmd5]Committed to branch[/url]

... not to mention replacing them with 3D floors. Doing that will indeed improve performance quite a bit - but of course this cannot be from inside the engine.

You couldn't really use this to affect Frozen Time because this is a ZScript request and ZScript can't modify map data enough to remove parts of the map (you'd have to remove the copious amounts of double sided lines, which is what trips the renderer up) since that would require nodes to be rebuilt while the game is running.

Wait, so with that we could finally fix the frozen time , remove the gross hack bridge and add a proper 3D floor for +100fps? :wub:

And also, people are already doing workarounds for doing the same thing (couf brutal doom came in mind) so why not add THE oficial way of checking what mods/iwads the player is playing (I never played with that feature but for map specific changes I'd get the map name + the player Spawn pos and angle, I don't think there would be maps with the same map name + the same player Spawn coord)

Honestly I'd rather have this than the dozens of gross hacks that exist because this doesn't.

(Please, I even attempted to torture myself by implementing MD5 in ZScript itself)

Let's be real though: who [i]doesn't[/i] enjoy looking at butts? 8-)

[quote="Rachael"]I think the important question is, what exactly are you trying to prevent by blocking this feature?

It's literally 7 lines of code that are copy-pasted and modified from another 7 lines (so about 2 min worth of work max), so there's something wrong with this that you think will actually happen if it's exposed.[/quote]Someone might make a mod that spawns an actor at the start of E1M1 that's just a big billboarded sprite of the text "XASER IS A BUTT AND ENJOYS LOOKING AT AND THINKING ABOUT BUTTS". Which is both libel [i]and[/i] slander, for Xaser is a saint and incapable of impure thoughts and/or actions.

[quote="Graf Zahl"]Wait until I slightly randomize the spawn positions of monsters and players... :twisted: :mrgreen: :laff: :flamethrower:[/quote]
I think the important question is, what exactly are you trying to prevent by blocking this feature?

It's literally 7 lines of code that are copy-pasted and modified from another 7 lines (so about 2 min worth of work max), so there's something wrong with this that you think will actually happen if it's exposed.

Wait until I slightly randomize the spawn positions of monsters and players... :twisted: :mrgreen: :laff: :flamethrower:

I'm pretty sure people were doing hacks to check maps before ZScript was even a thing.
And Brutal Doom (as bad as it is) somehow checks maps, and that can't use ZScript, so that shows it's certainly possible to hackily check maps with DECORATE + ACS.

Class PyCodeGen
{
    play string levelCode()
    {
        //G_PickPlayerStart(int pnum, int flags = 0);
        string checkcode;
        int playerposes[4];
        for(int i = 0;i<4;i++)
        {
            
            vector3 getvec = G_PickPlayerStart(i);
            playerposes[i] = getvec.x+getvec.y+getvec.z;
        }
        checkcode = level.MapName..checkcode..playerposes[0]..playerposes[1]..playerposes[2]..playerposes[3]..level.Sides[0].GetTexture(1);
        checkcode.ToUpper();
        Console.Printf("PyCode: "..checkcode);
        return checkcode;
    }
}

Already people are inventing ways of doing it too.

From DrByspy on Discord:
[code]Class PyCodeGen
{
play string levelCode()
{
//G_PickPlayerStart(int pnum, int flags = 0);
string checkcode;
int playerposes[4];
for(int i = 0;i<4;i++)
{

vector3 getvec = G_PickPlayerStart(i);
playerposes[i] = getvec.x+getvec.y+getvec.z;
}
checkcode = level.MapName..checkcode..playerposes[0]..playerposes[1]..playerposes[2]..playerposes[3]..level.Sides[0].GetTexture(1);
checkcode.ToUpper();
Console.Printf("PyCode: "..checkcode);
return checkcode;
}
}[/code]

Exactly. The idea is to expose [b]level.md5[/b] byte array and (maybe) to add a function that return a checksum as readable string like those we have in [b]compatibility.txt[/b] file.

Sure this can be used by mods to stop functioning right on a particular map.
But this can be achieved via existing functionality even without reading lumps.
If somebody will create a mod that will explicitly refuse to work properly with some map(s) then player must blame such mod maker.

I agree that hash check is fragile. Although checking many properties of a map can break any moment too for the same reason.
At least this helps to stop the invention of more and more comprehensive hacks to detect an exact map.