BlockLinesIterator is broken(?)

[Fishytza]

Tested with GZDoom 4.7.1 and g4.8pre-310-g1c4d48f5f

In short, the iterator will sometimes fail to detect lines that are right next to the (actor's) position where the iterator is created.

This PK3 has a replacement MAP01, but really, you can test this with any map. It also has a event handler that creates the line iterator where ever player 1 is with a search radius of 64. It prints the index of each found line and spawns a visual indicator in the middle of the line.

bmap-line-iterator-test.pk3

(2.81 KiB) Downloaded 40 times

In the test map, for example, no matter how close I get to it the iterator will never find linedef 11.
And right at the start, you can see it detects line 6 twice.

[Fishytza]

Here's an interesting fact. The iterator works as intended if I don't spawn any actors until after all lines are found.

Like so:

---

Code: Select all

class TestLineIterator : EventHandler
{
	override void WorldTick ()
	{
		Array<Line> foundLines;

		let it = BlockLinesIterator.Create(players[0].mo, 64);
		while (it.Next())
		{
			Line lin = it.curLine;
			foundLines.Push(lin);
		}

		if (foundLines.Size())
		{
			String text = "Iterator found lines: ";
			for (int i = 0; i < foundLines.Size(); ++i)
			{
				text = text .. foundLines[i].Index() .. " ";

				//Spawn indicator in front of the middle of the line
				Line lin = foundLines[i];
				double angle = VectorAngle(lin.delta.x, lin.delta.y) - 90;
				vector3 position = (lin.v1.p + lin.delta/2, Actor.ONFLOORZ);
				position.x += cos(angle);
				position.y += sin(angle);
				Actor.Spawn("FoundByIterator", position);
			}
			Console.MidPrint(null, text);
		}
	}
}

So I'm not supposed to spawn actors while iterating through lines.
Should this be dismissed as a [User Error] or is it still a bug?

[Graf Zahl]

Thanks for that bit of info. I think the problem here comes from the BlockLinesIterator using 'validcount' to weed out duplicates. That, however, means that you cannot call actions from there that also use validcount. Actor spawning is one of these things.

Here's the problem: Trying to fix this will be very performance-costly, because the only way would be to use a check array like the BlockThingsIterator - and that check array is one of the biggest performance killers compared to simpler Doom ports. So, I think the cost would be higher than the benefits, which means, better leave it as i t is and accept the limitation

[Fishytza]

better leave it as it is and accept the limitation

Will do.