[Latest]DUMP v2 no longer loads

[Major Cooke]

http://forum.zdoom.org/viewtopic.php?t=51072

Using this commit

Just trying to boot this up immediately shuts down zdoom.

[Graf Zahl]

I suspect the same thing you already reported.Does it work with my fix from today?

[Major Cooke]

Using this commit

Nope. I compiled the very latest where you added the self reference warning.

[_mental_]

Most likely a call to FMultiPatchTexture::CheckForHacks() must be deferred, i.e. moved to recently added ResolvePatches() function like I did in this PR.

[Graf Zahl]

Thanks. Although this mod shows another problem, thanks to some bogus texture definitions (Jeez, people, the texture namespaces exist for a reason, not to be ignored at will!)

[Major Cooke]

It still doesn't load. Instantly exits out, and I updated my code.

I'm on a 64-bit version, using windows 10, set as RelWithDebugInfo.

[_mental_]

So where did it crash?

[Major Cooke]

Oh shit, I recompiled the wrong branch. My mistake.

However...

---

I think this could be a bit more orderly.

[Graf Zahl]

Yep. Seems I mised the linefeed.
Those messages are only on in developer mode, btw.

[Major Cooke]

Also two warnings in textures.cpp, unused h and w variables.

Code: Select all

3>C:\Games\doom 2\zdoom\src\textures\texture.cpp(619): warning C4101: 'h': unreferenced local variable
3>C:\Games\doom 2\zdoom\src\textures\texture.cpp(618): warning C4101: 'w': unreferenced local variable