Scripting branch testing

[randi]

As some of you have no doubt noticed, there is a scripting branch for ZDoom. At the moment, there aren't any useable new features. On the other hand, there have been several significant under-the-hood changes. Right now I would like to verify that it behaves identically to the version in trunk. I am particularly interested in its behavior with DECORATE-heavy wads, since action functions are now executed with a general purpose VM. At the moment, it writes a disasm.txt file showing the disassembly for all action functions, if anyone is interested in what this looks like.

So if you feel like trying it out and helping me out, please download and leave feedback here.

[edward850]

It crashes when starting a new game with Zen Dynamics (zendyn_x.wad).

[Kinsie]

Found a bug! Not sure if it's on my end or yours. From the Reelism DECORATE...

---

Code: Select all

actor Car1
{
	obituary "%o was hit by a parked car."
	health 300
	radius 56
	height 56
	mass 10000
	deathsound "weapons/rocklx"
	+SOLID
	+SHOOTABLE
	+DONTGIB
	+NOICEDEATH
	+CANPASS
	+NOBLOODDECALS
	bloodtype "MetalSpark"
	states
	{
	Spawn:
		CARZ A 6
		loop
	Death:
		CARZ A 0
		CARZ A 0
		CARZ A 0 bright Radius_Quake(10,60,0,120,0)
		CARZ A 0 bright A_Explode(150)
		CARZ A 0 ThrustThingZ(0,64,0,1)
		CARZ AAAAAAAAAAAAAAAAAAAAA 0 A_CustomMissile("DEBRIS",random(16,56),0,random(0,360),2,random(4,32))
		CARZ A 0 A_PlaySound("weapons/explodedist",CHAN_WEAPON,1,0,ATTN_NONE)
		CARZ A 0 A_PlaySound("weapons/explode",CHAN_VOICE)
		CARZ A 0 A_Quake(6,8,0,2048,"weapons/explodedist")
		CARZ A 0 A_SpawnItemEx("Fire",0,0,16,16,0,0,random(0,360))
	SmashUp:
		CARZ A 0 bright A_Explode(150)
		CARZ A 8 A_SpawnItemEx("Spawner_Explosion_Normal1",random(0,30),random(0,30),random(0,30),0,0,0,random(0,360))
		CARZ A 0 A_PlaySound("weapons/explodedist",CHAN_WEAPON,1,0,ATTN_NONE)
		CARZ A 0 A_PlaySound("weapons/explode",CHAN_VOICE)
		CARZ A 0 A_Quake(6,8,0,2048,"weapons/explodedist")
		CARZ A 0 A_SpawnItemEx("Fire",0,0,16,16,0,0,random(0,360))
		CARZ A 0 A_JumpIf(z == floorz,"SmashUpEnd")
		loop
	SmashUpEnd:
		CARZ A 0 bright A_Explode(150)
		CARZ AAAAAAAAAAAAAAAAAAAAA 0 A_CustomMissile("DEBRIS",random(16,56),0,random(0,360),2,random(4,32))
		CARZ AAAAAAAAAAAAAAAAAAAAA 0 A_CustomMissile("RobotShards",random(16,56),0,random(0,360),2,random(4,32))
		CARZ A 0 A_SpawnItemEx("Spawner_Explosion_Normal1",random(0,30),random(0,30),random(0,30),0,0,0,random(0,360))
		CARZ A 0 A_SpawnItem("MapFireMedium")
		stop
	}
}

When killed, this actor should bounce up into the air, spewing explosions, then stop and get deleted when it hits the ground. In this build, it never gets deleted, it just sits there creating explosions forever.

[Major Cooke]

I could give this a shot with AEons of Death. That is highly action function extensive to the extreme... Will give it a boot-up soon.

[Enjay]

AEons of death probably would be the "acid test" for this right enough.

[Major Cooke]

Oooh yeah, especially all the special effects I've coded for it!

[Edward-san]

yeah and how much time is required to track down the real problem?

btw, something related to zscript branch: does the compilation with linux require some more packages than the ones listed in the wiki? Because, as I said in the 'Zdoom in Linux' thread, I was not able to compile it from scratch, with the same settings as the normal compilation...

[randi]

Updated first post with a new build that addresses the problems pointed out so far.

AEons of Death runs, but I'm not familiar enough with it to know if it's working correctly or not.

btw, something related to zscript branch: does the compilation with linux require some more packages than the ones listed in the wiki?

It shouldn't. I built it successfully with MinGW a few days ago, and that uses the same build system as for Linux.

[edward850]

Updated first post with a new build that addresses the problems pointed out so far.

It appears to be the exact same build from yesterday.

[Blzut3]

You forgot to make ZDoom depend on zcc-parse.c:

Code: Select all

Index: src/CMakeLists.txt
===================================================================
--- src/CMakeLists.txt  (revision 3910)
+++ src/CMakeLists.txt  (working copy)
@@ -914,6 +914,7 @@
 )
 
 set_source_files_properties( xlat/parse_xlat.cpp PROPERTIES OBJECT_DEPENDS "${CMAKE_CURRENT_BINARY_DIR}/xlat_parser.c" )
+set_source_files_properties( zscript/zcc_parser.cpp PROPERTIES OBJECT_DEPENDS "${CMAKE_CURRENT_BINARY_DIR}/zcc-parse.c" )
 set_source_files_properties( sc_man.cpp PROPERTIES OBJECT_DEPENDS "${CMAKE_CURRENT_BINARY_DIR}/sc_man_scanner.h" )
 
 if(${CMAKE_SYSTEM_NAME} STREQUAL "SunOS")

Edit: And I guess while I'm at it here are the zscript related warnings:

Code: Select all

[ 97%] Building CXX object src/CMakeFiles/zdoom.dir/zscript/vmexec.o
In file included from /home/blzut3/Code/ZDoom/branches/scripting/src/zscript/vmexec.cpp:88:0:
/home/blzut3/Code/ZDoom/branches/scripting/src/zscript/vmexec.h: In static member function ‘static int VMExec_Checked::Exec(VMFrameStack*, const VMOP*, VMReturn*, int)’:
/home/blzut3/Code/ZDoom/branches/scripting/src/zscript/vmexec.h:721:27: warning: comparison is always true due to limited range of data type [-Wtype-limits]
/home/blzut3/Code/ZDoom/branches/scripting/src/zscript/vmexec.h:734:27: warning: comparison is always true due to limited range of data type [-Wtype-limits]
/home/blzut3/Code/ZDoom/branches/scripting/src/zscript/vmexec.h:747:27: warning: comparison is always true due to limited range of data type [-Wtype-limits]

[randi]

It appears to be the exact same build from yesterday.

Got the new one up for reals this time.

[edward850]

Some issues with Zen Dynamics:

• Ammo counts aren't shown in any hud, and weapons you have aren't shown in the alt-hud.
• It appears the grenades aren't replacing properly. All grenade pickups are the Zdoom.pk3 grenades.

[Edward-san]

You forgot to make ZDoom depend on zcc-parse.c:

Ugh, I didn't search hard enough. That change worked.

Still talking about gcc warnings, I get constantly these warnings each .o file:

Code: Select all

/home/edward-san/zdoom/branch/scripting/src/tarray.h: In member function ‘hash_t THashTraits<float>::Hash(float)’:
/home/edward-san/zdoom/branch/scripting/src/tarray.h:453:50: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
/home/edward-san/zdoom/branch/scripting/src/tarray.h: In member function ‘hash_t THashTraits<double>::Hash(double)’:
/home/edward-san/zdoom/branch/scripting/src/tarray.h:460:53: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]

[edit]Each time I run ./zdoom and then I exit, I get in the folder a file called 'disasm.txt', I don't know its purpose. :\

[Gez]

Randy's opening paragraph wasn't that TL;DR...

At the moment, it writes a disasm.txt file showing the disassembly for all action functions, if anyone is interested in what this looks like.

[Edward-san]

I noticed that A_Explode doesn't do the splash damage. You can verify by using a normal rocket launcher against the zombies in map01. Also, if you make explode the barrels they won't cause any harm to the player.