[2.8.1 && 2.9pre]Bug: Thing_Stop Incorrect Execution

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
Post Reply
User avatar
Siberian Tiger
Posts: 476
Joined: Fri Jun 12, 2009 11:23 pm
Preferred Pronouns: He/Him
Operating System Version (Optional): KUbuntu 22.04.1 LTS
Graphics Processor: nVidia (Modern GZDoom)
Location: United States
Contact:

[2.8.1 && 2.9pre]Bug: Thing_Stop Incorrect Execution

Post by Siberian Tiger »

Following up with this thread, I have ran into a lot of trouble with using 'THING_STOP' function. When ever I make a modification to a map that contains a THING trigger [Sector Actions >> Actor Hits Floor >> THING_STOP], they simply will not work correctly. I have attached a PWAD that contains an edited version of a map that demonstrates this very issue.
I am not exactly sure why this bug happens and what causes it to happen exactly.
Spoiler: Demonstration Jump Pad
Jump Pad Logic:
  • THING_STOP
  • PLAYSOUND (jump pad sound)
  • ThrustThingZ
  • ThrustThing (Optional)
Load Order example:

Code: Select all

ZDoom.exe -iwad doom2 -file TGRDM3_v1-4a94ba4.pk7 MAP03.wad
Required:
TGRDM3 Dev. Build
MAP03.7z
Modified NoirLust
(11.54 KiB) Downloaded 36 times
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49234
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: [2.8.1 && 2.9pre]Bug: Thing_Stop Incorrect Execution

Post by Graf Zahl »

Has this worked before?

But whatever this is, Thing_Stop only does one thing: It sets the actor's velocity to zero. And that's all it does.
User avatar
Siberian Tiger
Posts: 476
Joined: Fri Jun 12, 2009 11:23 pm
Preferred Pronouns: He/Him
Operating System Version (Optional): KUbuntu 22.04.1 LTS
Graphics Processor: nVidia (Modern GZDoom)
Location: United States
Contact:

Re: [2.8.1 && 2.9pre]Bug: Thing_Stop Incorrect Execution

Post by Siberian Tiger »

Graf Zahl wrote:Has this worked before?
Yes, that is - if the map is NEVER changed - at all. For example, once the jump pads are working, they can easily break once the map is changed. For example, the map presented in this topic, is a modified version of MAP03 in TGRDM3. All but one jump pad worked perfectly fine (though everything worked fine with GZD 2.1), but after I originally shrunk the map for a bug report with Zandronum, all but one jump pad broke. I don't know nor understand as to why this happens, the sector references containing such triggers never changed, yet - breaks.

EDIT:
I really wish I had something more useful to provide instead of a vague response, but this complication I have been having with using that function, I am merely left confused.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49234
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: [2.8.1 && 2.9pre]Bug: Thing_Stop Incorrect Execution

Post by Graf Zahl »

If you refuse to use scripts and insist to depend on a defined order in which the sector actions are fired, you are in for trouble. I'm not surprised that this causes problems.
You really should do this in one single ACS script called from ONE sector action and not with such a messy setup.
User avatar
Siberian Tiger
Posts: 476
Joined: Fri Jun 12, 2009 11:23 pm
Preferred Pronouns: He/Him
Operating System Version (Optional): KUbuntu 22.04.1 LTS
Graphics Processor: nVidia (Modern GZDoom)
Location: United States
Contact:

Re: [2.8.1 && 2.9pre]Bug: Thing_Stop Incorrect Execution

Post by Siberian Tiger »

Graf Zahl wrote:If you refuse to use scripts and insist to depend on a defined order in which the sector actions are fired, you are in for trouble. I'm not surprised that this causes problems.
You really should do this in one single ACS script called from ONE sector action and not with such a messy setup.
Alright, so I'll need to shift to a script rather than thing triggers.

I'll start looking into this soon; thank you for the help.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49234
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: [2.8.1 && 2.9pre]Bug: Thing_Stop Incorrect Execution

Post by Graf Zahl »

To me this looks at least that your actions are performed out of order so this is the first thing that needs to be checked.
User avatar
Siberian Tiger
Posts: 476
Joined: Fri Jun 12, 2009 11:23 pm
Preferred Pronouns: He/Him
Operating System Version (Optional): KUbuntu 22.04.1 LTS
Graphics Processor: nVidia (Modern GZDoom)
Location: United States
Contact:

Re: [2.8.1 && 2.9pre]Bug: Thing_Stop Incorrect Execution

Post by Siberian Tiger »

Graf Zahl wrote:To me this looks at least that your actions are performed out of order so this is the first thing that needs to be checked.
What I did was create a script 'JumpPad' which will handle the jumping pads that needs 'Thing Stop'. So far, this has solved all of my troubles with the jumping pads on (G)ZDoom's recent builds. I am still having a bit of difficulty with Zandronum at the present moment, but - I am confident a resolution will happen soon.

Thank you for helping me :)

(this report can be closed)

Graf Zahl wrote:To me this looks at least that your actions are performed out of order so this is the first thing that needs to be checked.
By chance, is there a way to have THING's perform on a sequential order or is scripting the only way?
User avatar
randi
Site Admin
Posts: 7749
Joined: Wed Jul 09, 2003 10:30 pm
Contact:

Re: [2.8.1 && 2.9pre]Bug: Thing_Stop Incorrect Execution

Post by randi »

Scripting is the only way to guarantee ordering.
User avatar
Siberian Tiger
Posts: 476
Joined: Fri Jun 12, 2009 11:23 pm
Preferred Pronouns: He/Him
Operating System Version (Optional): KUbuntu 22.04.1 LTS
Graphics Processor: nVidia (Modern GZDoom)
Location: United States
Contact:

Re: [2.8.1 && 2.9pre]Bug: Thing_Stop Incorrect Execution

Post by Siberian Tiger »

randi wrote:Scripting is the only way to guarantee ordering.
Thank you for clarifying.
Post Reply

Return to “Closed Bugs [GZDoom]”