Console memory lag issue

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
User avatar
edward850
Posts: 5886
Joined: Tue Jul 19, 2005 9:06 pm
Location: New Zealand
Contact:

Re: Console memory lag issue

Post by edward850 »

unknownna
Posts: 215
Joined: Sat Oct 06, 2007 4:45 pm

Re: Console memory lag issue

Post by unknownna »

Thank you very much for that build, edward850!
Graf Zahl wrote:As a quick test: Comment out the I_PrintStr call in c_console.cpp:PrintString to see if this helps resolve the lag.
Indeed, that took care of the issue. It's now as smooth as 1.22/1.23b33 (ZDaemon).
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49223
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: Console memory lag issue

Post by Graf Zahl »

I addressed this by locally buffering the RichEdit control's content while that control is invisible. The content now gets added only if some later error forces display of that control again.
I'm waiting for confirmation now.
unknownna
Posts: 215
Joined: Sat Oct 06, 2007 4:45 pm

Re: Console memory lag issue

Post by unknownna »

Graf Zahl wrote:I'm waiting for confirmation now.
I'll need someone to supply me with a test build again. Or I could wait for the next build at DRD (which could take days).
unknownna
Posts: 215
Joined: Sat Oct 06, 2007 4:45 pm

Re: Console memory lag issue

Post by unknownna »

Ok, using zdoom-2.8pre-1669-gadd52d4.7z I was able to confirm that the issue has been resolved. However, it takes ages for it to generate an error report now if the console was full of stuff before the crash occurred. But I suppose it's fine for most cases though. It'll only take a while if it crashes after hours of play.

Thank you very much for fixing this issue, Graf. I really appreciate it. Thanks!
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49223
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: Console memory lag issue

Post by Graf Zahl »

Out of curiosity, how long does it take? Several seconds, a minute or even more?
unknownna
Posts: 215
Joined: Sat Oct 06, 2007 4:45 pm

Re: Console memory lag issue

Post by unknownna »

It took around 36 seconds for it to generate the report when crashing after having copy-pasted the command in the OP. That's the equivalence of having played for around 1.5-2 hours on a high-intensity Zandronum CTF server I think.
unknownna
Posts: 215
Joined: Sat Oct 06, 2007 4:45 pm

Re: Console memory lag issue

Post by unknownna »

Graf, several of the Zandronum developers are wondering whether you're going to improve the fix? Apparently it's not good enough for backporting in its current state.
unknownna wrote:It took around 36 seconds for it to generate the report when crashing after having copy-pasted the command in the OP.
They're not too happy with this part.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49223
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: Console memory lag issue

Post by Graf Zahl »

To be honest, I have no good idea what to do here. The only way to get rid of the delay is not to add the messages to the log window and that's not a good option.
unknownna
Posts: 215
Joined: Sat Oct 06, 2007 4:45 pm

Re: Console memory lag issue

Post by unknownna »

Graf, would it be possible to at least have a text displayed somewhere in the error window that says "Generating crash report, please wait." or something like that? I think the average, casual user would find it very confusing to just see a bunch of text streaming down the window fast without any further explanation on what's going on. Presumably the user would just close the window before ZDoom/Zandronum got a chance to generate the report.
Attachments
error_window.png
error_window.png (6.98 KiB) Viewed 711 times
Post Reply

Return to “Closed Bugs [GZDoom]”