Speed property for A_Raise/A_Lower

[Minigunner]

As mentioned in the wiki articles for A_Raise and A_Lower, there is a method for modifying the speed at which a weapon raises/lowers; however, it is limited in the factor in which the speed is multiplied (e.g. 1/3, 1/2, 2, 3, ect.), and a slower raise/lower using this method is (of course) not as smooth.
I ask that a Speed property be implemented for more flexibility, especially since mods such as DoomRL Arsenal make liberal use of the current method.

Also, as was pointed out to me, there's already a variable for the raise/lower amount (which is hard-set to 6.0). This could be used for the above suggested property such that A_Raise(3.0) would raise the weapon at half the speed, similar to the speed of a 2-tic A_Raise frame. Alternatively, for simplicity, the property can be a factor, so that A_Raise(0.5) would result in the same.

[NeuralStunner]

I would say that a speed factor is better.

[D2JK]

Good that I saw this before submitting a duplicate request.

I agree this addition would be rather useful. For fast weapon switches, I currently use the "weave in zero-tic A_Lowers/Raises" method. Also, in lack of proper sprites, they're often useful for weapon reloads, cooldowns, etc (or to lower the gun when delivering a quick punch)... the default speed (6, as pointed out by OP) just isn't always desirable.

The Offset - keyword is another possibility, but it would simplify the decorate code if, instead of writing a great number of Offsets, you could just adjust the speed parameter in A_Lower/Raise instead, and loop it.

If you don't mind, I'll post a few illustrative examples.

Example 1:

---

Code: Select all

Select:
 WEAP A 1 A_Raise
 WEAP A 0 A_Raise
 Loop

Becomes:

Code: Select all

Select:
 WEAP A 1 A_Raise(12)
 Loop

Example 2:

---

Code: Select all

Reload:
 WEAP A 1 Offset(0,44)
 WEAP A 1 Offset(0,54)
 WEAP A 1 Offset(0,64)
 WEAP A 1 Offset(0,74)
 WEAP A 1 Offset(0,84)
 WEAP A 1 Offset(0,94)
 WEAP A 20 A_PlaySound("Reload")
 WEAP A 1 Offset(0,84)
 WEAP A 1 Offset(0,74)
 WEAP A 1 Offset(0,64)
 WEAP A 1 Offset(0,54)
 WEAP A 1 Offset(0,44)
 WEAP A 1 Offset(0,34)
 Goto Ready

Becomes:

Code: Select all

Reload:
 WEAP AAAAAA 1 A_Lower(10)
 WEAP A 20 A_PlaySound("Reload")
 WEAP AAAAAA 1 A_Raise(10)
 Goto Ready

[Xtyfe]

This would be awesome, heavier guns could take a longer time for example.

[Onar4241]

This should be added. I'd like to increase the speed in a specific manner.

[D2JK]

Since nobody seems to be tackling this, I'll give it a shot.

Would this code work?

---

Code: Select all

// A_Lower

DEFINE_ACTION_FUNCTION(AInventory, A_Lower)
 {  
  ACTION_PARAM_START(1);
  ACTION_PARAM_INT(yspeed, 6);

  player_t *player = self->player;
  pspdef_t *psp;
  if (NULL == player)
   {
    return;
   }
  psp = &player->psprites[ps_weapon];
  if (player->morphTics || player->cheats & CF_INSTANTWEAPSWITCH)
   {
    psp->sy = WEAPONBOTTOM;
   }
  else
   {
    psp->sy += yspeed;
   }
  if (psp->sy < WEAPONBOTTOM)     // Not lowered all the way yet
   { 
    return;
   }
  if (player->playerstate == PST_DEAD)     // Player is dead, so don't bring up a pending weapon
   {
    psp->sy = WEAPONBOTTOM;     // Player is dead, so keep the weapon off screen    
    P_SetPsprite (player, ps_weapon, NULL);
    return;
   }  
  P_SetPsprite (player, ps_flash, NULL);     // [RH] Clear the flash state. Only needed for Strife.
  P_BringUpWeapon (player);
 }

The original code can be found in OP's link.