OPEN/ENTER script order discrepency

[Ijon Tichy]

So as a result of tracking down inconsistent script orders in Zandronum, I noticed that in ZDoom, OPEN scripts run before ENTER scripts in single player and coop, but after ENTER scripts in deathmatch. Is that intentional?

[edward850]

It's unintentional, however this is because script execution order is undefined. Scripts that rely on it would be better off being rewritten, as the rules can change at any time.
Also, singleplayer/coop has ENTER scripts running before OPEN at the moment. You may want to recheck your analysis.

[Ijon Tichy]

I did.



Also, considering a map needs to be opened before anyone can enter it, it seems pretty natural for OPEN to run before ENTER.

Guess Zandronum's going to be making this explicit, then.

[edward850]

Your analysis is false: http://pastebin.com/wyUijLKc
Take note of lines 14 and 15. You are seeing the result of how the ACSVM steps down each executed script by number, however ENTER scripts are still being called before OPEN scripts. This is exactly why the behaviour is undefined as you cannot rely on it.

[Ijon Tichy]

So you're saying the very output GZDoom (checked out and compiled just 2 minutes ago from the Git repo, so I know you aren't bullshitting me) puts out is wrong?

Code: Select all

#include "zcommon.acs"
#library "opennotfirst"

int MapVar = 0;

script 301 OPEN { Print(s:"Open has run, time = ", d:Timer(), s:", mapvar = ", d:MapVar++); }
script 302 ENTER { Print(s:"Enter has run, time = ", d:Timer(), s:", mapvar = ", d:MapVar++); }

(why the fuck does gzdoom think I'm using oss I told it to use alsa god damn why are you so dumb)
(why the fuck can I not think straight brain god damn why are you so dumb)

edit: Even flipping the order of the scripts' definitions and swapping their script numbers so that OPEN is 302 and ENTER is 301 doesn't change it. It's clearly been this way since 2.3.1, since Zandronum 1.2, based off of that release, does this too. I don't know what the hell you're seeing, but it doesn't line up with the output I'm getting.

edit2: Also, ZDoom itself isn't exactly clean of warnings and undefined behaviour itself and it still runs fine, so whatever maaaaaaaaaaaaaaaan

[Graf Zahl]

The order is undefined. Starting a script merely means queuing it for execution. Execution itself depends on the order in the script table.

[TerminusEst13]

The order is undefined. Starting a script merely means queuing it for execution. Execution itself depends on the order in the script table.

I just swapped around the order of the Enter script and the Open script so that the Enter script was before Open.
Open still ran before Enter.





If anyone would like to check for themselves, I've uploaded a test .pk3 I made with ijon's script.