[r4029] Monsters on 3D floors trigger "Actor Hits Floor"

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
Post Reply
User avatar
Xaser
 
 
Posts: 10772
Joined: Sun Jul 20, 2003 12:15 pm
Contact:

[r4029] Monsters on 3D floors trigger "Actor Hits Floor"

Post by Xaser »

So, apparently, in the latest SVNs + latest official GZDoom, the bosses in ZDCMP2 get instakilled as soon as the fight starts. What's happening is that the arena is a big 3D floor over lava, and there's an "Actor Hits Floor" thing on the lava below that's meant to kill players and monsters that step on it. At some point, though, there was a change that ended up causing monsters (but not players) to trigger "Actor Hits Floor" when stepping on the floor of a 3D sector on top of it, which is not desired. Hence the bosses get insta-burned once trying to move. D:

To test quickly, start the map and puke script 888. This will place you right outside the boss arena; cross the bridge, start the match, and watch as they die immediately after stepping down onto the ring with the glass.
Last edited by Xaser on Sun Jan 20, 2013 2:06 am, edited 1 time in total.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49056
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: [Latest] Monsters on 3D floors trigger "Actor Hits Floor

Post by Graf Zahl »

What's 'latest'. If this hangs around for longer, it won't be easy to tell so please add a real revision number.
Gez
 
 
Posts: 17833
Joined: Fri Jul 06, 2007 3:22 pm

Re: [r4029] Monsters on 3D floors trigger "Actor Hits Floor"

Post by Gez »

Xaser said it was broken in GZDoom 1.7.00, so the bug was introduced somewhere between r3794 and r4002
User avatar
TheDarkArchon
Posts: 7656
Joined: Sat Aug 07, 2004 5:14 am
Location: Some cold place

Re: [r4029] Monsters on 3D floors trigger "Actor Hits Floor"

Post by TheDarkArchon »

I can confirm that it's broken in GZDoom r1469, based off ZDoom r3963
Gez
 
 
Posts: 17833
Joined: Fri Jul 06, 2007 3:22 pm

Re: [r4029] Monsters on 3D floors trigger "Actor Hits Floor"

Post by Gez »

It is probably a consequence of this.
User avatar
Xaser
 
 
Posts: 10772
Joined: Sun Jul 20, 2003 12:15 pm
Contact:

Re: [r4029] Monsters on 3D floors trigger "Actor Hits Floor"

Post by Xaser »

That looks like a possible cause, indeed. Thanks for the pinpoint.
User avatar
NeuralStunner
 
 
Posts: 12325
Joined: Tue Jul 21, 2009 12:04 pm
Preferred Pronouns: He/Him
Graphics Processor: nVidia with Vulkan support
Location: capital N, capital S, no space
Contact:

Re: [r4029] Monsters on 3D floors trigger "Actor Hits Floor"

Post by NeuralStunner »

If that is the culprit, a compat-friendly fix might be difficult. Ideally (for me at least), HitFloor/HitCeiling would only count a 3D floorif the action thing is in its control sector. But I'm sure that wouldn't be simple and would most likely break other things.
User avatar
TheDarkArchon
Posts: 7656
Joined: Sat Aug 07, 2004 5:14 am
Location: Some cold place

Re: [r4029] Monsters on 3D floors trigger "Actor Hits Floor"

Post by TheDarkArchon »

NeuralStunner wrote:If that is the culprit, a compat-friendly fix might be difficult. Ideally (for me at least), HitFloor/HitCeiling would only count a 3D floorif the action thing is in its control sector. But I'm sure that wouldn't be simple and would most likely break other things.
Given that the ZDCMP2 lava script already has an exception for Grells, it'll trivial to extend the protection to the boss gits.
User avatar
Xaser
 
 
Posts: 10772
Joined: Sun Jul 20, 2003 12:15 pm
Contact:

Re: [r4029] Monsters on 3D floors trigger "Actor Hits Floor"

Post by Xaser »

That'd actually work as a simple workaround, and now I feel silly for not thinking of that. It's still a bug, though -- if you'll notice, the player never triggers the script, yet monsters do. Inconsistencies like that aren't on purpose. :P
User avatar
randi
Site Admin
Posts: 7746
Joined: Wed Jul 09, 2003 10:30 pm
Contact:

Re: [r4029] Monsters on 3D floors trigger "Actor Hits Floor"

Post by randi »

Fixed in r4152.
Post Reply

Return to “Closed Bugs [GZDoom]”