Mysterious bloodtype-inheritance crash? [Latest SVN]

[Xaser]

Okay, I've got a weird one.

I've attached a .zip containing a test wad + crash report. I have a custom bloodtype (HacxDigitWhite) that works just fine, but there's some kind of bizarre thing going on where the classes that inherit from it (HacxDigitGreen, etc.) will sometimes crash the game when used as blood types.

Included in the test wad are some "file" objects (HacxFileWhite, HacxFileGreen, etc.) that you can summon, push around, and shoot. The White one (base actor) works just fine, but if you try and summon and shoot HacxFileGreen (or any of the others), ZDoom will randomly crash when trying to spawn the digit actor.

I've narrowed down the error to the Digit actors, since swapping HacxFileWhite's blood type to HacxDigitGreen will cause the crash. It's likely something to do with the way inheritance is making the jump states work, but I really have no clue what and I'm pretty sure it shouldn't cause an access violation either way.

[randi]

Fixed in r3861.

PS. r3794 was not the "latest SVN" at the time you reported this.

[Graf Zahl]

The whole thing still needs some actor side changes

The blood spawning code autoselects one of the first 3 states depending on the damage. So for the base class it may jump directly into one of the later states.

[Xaser]

I must've forgotten to re-dump the crashlog after downloading the latest to see if the crash still occurred (it did).

Thanks for the fix, by the way.

[EDIT] Post-sniped. Never heard of this special behavior for blood spawning, though... I guess it's always been like this?

[DOUBLE-EDIT] Ah, that fixed it. Snuck a couple of extra frames and the crash has stopped. Weird that I've never noticed this about blood actors, though.

I'm guessing what was happening is that the shorter new Spawn state caused it to either randomly jump ahead to undefined data or go to the Spray state, which seemed to be borky according to the fix in the changelog.

[Kate]

Yes, it has always been like this. I know because I've run into a problem with this before - if the actor replacing blood has less than 3 states, the game will crash.

[Xaser]

Welp! I seem to be having a chronological posting crisis here.

Thanks and things, all.

[randi]

or go to the Spray state, which seemed to be borky according to the fix in the changelog.

Spray is only used when you're playing Strife, and the only thing borky about it was that it wasn't actually used.