[Recently?] DamageFactor "Normal" not working

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
Post Reply
User avatar
Xtyfe
Posts: 1490
Joined: Fri Dec 14, 2007 6:29 pm
Preferred Pronouns: He/Him
Operating System Version (Optional): Windows 11
Graphics Processor: nVidia with Vulkan support

[Recently?] DamageFactor "Normal" not working

Post by Xtyfe »

If I use DamageFactor "Normal" 0.0 on armor, I still get damaged by stuff without a damagetypes in my mod, such as monster melee attacks and lostsouls but not hitscans.

I swear this used to work, any willing to test?
Last edited by Xtyfe on Wed Jan 25, 2012 8:12 pm, edited 1 time in total.
User avatar
Xtyfe
Posts: 1490
Joined: Fri Dec 14, 2007 6:29 pm
Preferred Pronouns: He/Him
Operating System Version (Optional): Windows 11
Graphics Processor: nVidia with Vulkan support

Re: [Recently?] DamageFactor "Normal" not working

Post by Xtyfe »

I fixed my problem for both melee attacks and lost souls buy giving my armor the damagefactor "melee"
It seems that i misunderstood what "normal" does, or is that infact still a bug?
User avatar
NeuralStunner
 
 
Posts: 12328
Joined: Tue Jul 21, 2009 12:04 pm
Preferred Pronouns: No Preference
Operating System Version (Optional): Windows 11
Graphics Processor: nVidia with Vulkan support
Location: capital N, capital S, no space
Contact:

Re: [Recently?] DamageFactor "Normal" not working

Post by NeuralStunner »

"Normal" only applies to attacks that have no type.

Have you tried using DamageFactor without a type specificed at all?
User avatar
Xtyfe
Posts: 1490
Joined: Fri Dec 14, 2007 6:29 pm
Preferred Pronouns: He/Him
Operating System Version (Optional): Windows 11
Graphics Processor: nVidia with Vulkan support

Re: [Recently?] DamageFactor "Normal" not working

Post by Xtyfe »

I thought about it, but i wondered if that would cancel out the other damagetypes.
User avatar
DBThanatos
Posts: 3101
Joined: Fri Apr 14, 2006 3:17 pm
Location: in "the darkness that lurks in our mind"

Re: [Recently?] DamageFactor "Normal" not working

Post by DBThanatos »

NeuralStunner wrote:"Normal" only applies to attacks that have no type.
As far as I understood, that is not correct. "Normal" should protect against all damagetypes not included in the definition of the armor.

Source
User avatar
ChronoSeth
Posts: 1631
Joined: Mon Jul 05, 2010 2:04 pm
Location: British Columbia

Re: [Recently?] DamageFactor "Normal" not working

Post by ChronoSeth »

In the same thread, it's explained that "Normal" does in fact only apply to attacks with no damage type.

Though clarification from someone who knows exactly how this stuff works would be nice.
User avatar
FDARI
Posts: 1097
Joined: Tue Nov 03, 2009 9:19 am

Re: [Recently?] DamageFactor "Normal" not working

Post by FDARI »

Graf states very clearly that
---
DamageFactors "Normal", 0
DamageFactors "AllowedDamageTypeForThisMonster", 1.0 or whatever
---
means that the only damage type that does damage is "AllowedDamageTypeForThisMonster", while all other types are caught by the "Normal" type, and he says that he updated the code to make it actually work that way. While it is explained/asserted otherwise at locations in the thread, the aggregate of anecdotes, guesses, zdoom updates, assertions, corrections and counter-corrections is that "Normal" applies to any damage type that does not have a specific factor assigned.

You can always create a test (an actor that receives damage only from fire -- DamageFactor "Fire", 1.0 -- DamageFactor "Normal", 0 -- , a weapon that does fire damage and a weapon that does ice damage - and a fist or similar generic damage source to test untyped damage).
User avatar
DBThanatos
Posts: 3101
Joined: Fri Apr 14, 2006 3:17 pm
Location: in "the darkness that lurks in our mind"

Re: [Recently?] DamageFactor "Normal" not working

Post by DBThanatos »

ChronoSeth wrote:In the same thread, it's explained that "Normal" does in fact only apply to attacks with no damage type.
Not really. That's wrong. I wasnt linking to the thread. Instead, I was linking to the specific post...
ChronoSeth wrote:Though clarification from someone who knows exactly how this stuff works would be nice.
...where Graf Zahl (a certified developer (as in "Hi, Im purple")) clarifies how it should work. Just like FDARI did.

And to be more specific
Graf Zahl wrote:DamageFactor "Normal" is supposed to protect against all types of damage that don't have a specific factor assigned.
User avatar
randi
Site Admin
Posts: 7750
Joined: Wed Jul 09, 2003 10:30 pm
Contact:

Re: [Recently?] DamageFactor "Normal" not working

Post by randi »

Fixed. Apparently, it was deliberate that this did not work with armor, though I don't understand the justification, since it's counter to everything else that uses damage factors.
Post Reply

Return to “Closed Bugs [GZDoom]”