[Added] Remove doom_sbar.cpp

Moderator: Developers

Remove doom_sbar.cpp

Postby Blzut3 » Mon Dec 01, 2008 5:11 pm

As far as I am aware the SBarInfo implementation of the Doom status bar and its ZDoom HUD is accurate. If this patch is applied be sure to delete src/g_doom/doom_sbar.cpp.

doomsbar.zip


The Heretic HUD is almost possible, but a small question on that. Would including an animdefs entry for the health icon be acceptable?
Blzut3
Pronounced: B-l-zut
 
Joined: 24 Nov 2004

Re: Remove doom_sbar.cpp

Postby Graf Zahl » Mon Dec 01, 2008 6:07 pm

Sure. It's not the first HUD/statusbar icon that has. The rotating powerup icons also use such animations.
User avatar
Graf Zahl
 
Joined: 19 Jul 2003
Location: Germany

Re: Remove doom_sbar.cpp

Postby randi » Mon Dec 01, 2008 6:19 pm

I don't know about this. The native status bar is still faster than SBARINFO when done with software rendering, since it doesn't redraw everything every frame. It's not so much an issue with Windows any more, but it certainly is with Linux.
User avatar
randi
Site Admin
 
Joined: 09 Jul 2003

Re: Remove doom_sbar.cpp

Postby Graf Zahl » Mon Dec 01, 2008 6:40 pm

The irony being that this patch was done by a Linux user... ;)


I won't commit today though so if someone who can test says it's a bad idea I'll revert this patch before committing.
User avatar
Graf Zahl
 
Joined: 19 Jul 2003
Location: Germany

Re: Remove doom_sbar.cpp

Postby Blzut3 » Mon Dec 01, 2008 7:00 pm

randy wrote:It's not so much an issue with Windows any more, but it certainly is with Linux.

I don't notice any problems performance wise, but of course I am using a Q6600 processor.
Blzut3
Pronounced: B-l-zut
 
Joined: 24 Nov 2004

Re: Remove doom_sbar.cpp

Postby randi » Mon Dec 01, 2008 9:37 pm

Does SBARINFO respect the hud_scale cvar?
User avatar
randi
Site Admin
 
Joined: 09 Jul 2003

Re: Remove doom_sbar.cpp

Postby Blzut3 » Mon Dec 01, 2008 9:41 pm

Yes. It also shifts the upper right quadrant when vid_fps is enabled just like before.
Blzut3
Pronounced: B-l-zut
 
Joined: 24 Nov 2004

Re: Remove doom_sbar.cpp

Postby Graf Zahl » Tue Dec 02, 2008 6:34 pm

Any decision?
User avatar
Graf Zahl
 
Joined: 19 Jul 2003
Location: Germany

Re: Remove doom_sbar.cpp

Postby Blzut3 » Fri Dec 05, 2008 6:07 pm

I got around to testing on a slower coputer IBM TP T22: Pentium 3 900mhz I think.

320x200
With doom_sbar.cpp: ~122fps
Without doom_sbar.cpp: ~114fps

640x480
With doom_sbar.cpp: ~36fps
Without doom_sbar.cpp: ~35fps

I don't think sbarinfo is going to cause a whole lot of trouble for Linux users.
Blzut3
Pronounced: B-l-zut
 
Joined: 24 Nov 2004

Re: Remove doom_sbar.cpp

Postby Graf Zahl » Fri Dec 05, 2008 6:11 pm

You call that slow? Wait until Leileilol does such a comparison on his 486... :mrgreen:


(Obviously, I doubt that the relative difference will be more significant there... ;))


One question though: Was the second comparison with a scaled or unscaled statusbar?
User avatar
Graf Zahl
 
Joined: 19 Jul 2003
Location: Germany

Re: Remove doom_sbar.cpp

Postby Blzut3 » Fri Dec 05, 2008 6:25 pm

Scaled I think. (That's is the default correct?)

And I call it slower than a Core 2. ;)
Blzut3
Pronounced: B-l-zut
 
Joined: 24 Nov 2004

Re: Remove doom_sbar.cpp

Postby Graf Zahl » Sat Dec 06, 2008 5:23 am

I committed the change anyway. If someone doesn't like it it it may be reverted.
User avatar
Graf Zahl
 
Joined: 19 Jul 2003
Location: Germany


Return to Closed Feature Suggestions

Who is online

Users browsing this forum: No registered users and 2 guests