Probably forever - inquisitorshots originate too low.

[Enjay]

In this thread, http://forum.zdoom.org/viewtopic.php?f=3&t=32441 , I was trying to find a way to emulate the way that the inquisitor shots behave but I wanted to launch them higher up on the enemy because the sprite has cannons on its shoulders but the shots seem to come from down by his feet.

Then Edward-san posted the obvious question - "are you sure it's not a bug that should be reported?"

I was convinced that the shots had always been fired from a very low position but on checking the original game, they do not start as low as they do in ZDoom. It's hard to estimate but in the original game the shots seem to come from somewhere in the area indicated in this pic:



In ZDoom they start very low and often catch on low steps and so on, exploding long before they reach the player. This does not seem to be the case in the original but the very low res and lack of a "freeze" command in the original meant it was hard to get an accurate idea of exactly where they came from. I'm pretty sure that it is higher up than ZDoom anyway.

[Xtyfe]

Is this how they are in vanilla? I know for example for the revenants attacks are not exactly aligned in vanilla

[Enjay]

I was convinced that the shots had always been fired from a very low position but on checking the original game, they do not start as low as they do in ZDoom.

[Gez]

Blue-green on blue? I hope Randy isn't colourblind.

Anyway, looking at the ZDoom function and comparing it with ChocoStrife, I don't see a difference:
ZDoom:

---

Code: Select all

DEFINE_ACTION_FUNCTION(AActor, A_InquisitorAttack)
{
	AActor *proj;

	if (self->target == NULL)
		return;

	A_FaceTarget (self);

	self->z += 32*FRACBITS;
	self->angle -= ANGLE_45/32;
	proj = P_SpawnMissileZAimed (self, self->z, self->target, PClass::FindClass("InquisitorShot"));
	if (proj != NULL)
	{
		proj->velz += 9*FRACUNIT;
	}
	self->angle += ANGLE_45/16;
	proj = P_SpawnMissileZAimed (self, self->z, self->target, PClass::FindClass("InquisitorShot"));
	if (proj != NULL)
	{
		proj->velz += 16*FRACUNIT;
	}
	self->z -= 32*FRACBITS;
}

Choco:

---

Code: Select all

void A_InqGrenade(mobj_t* actor)
{
    mobj_t* mo;

    if(!actor->target)
        return;

    A_FaceTarget(actor);

    actor->z += MAXRADIUS;

    // grenade 1
    actor->angle -= (ANG45 / 32);
    mo = P_SpawnFacingMissile(actor, actor->target, MT_INQGRENADE);
    mo->momz += (9*FRACUNIT);

    // grenade 2
    actor->angle += (ANG45 / 16);
    mo = P_SpawnFacingMissile(actor, actor->target, MT_INQGRENADE);
    mo->momz += (16*FRACUNIT);

    actor->z -= MAXRADIUS;
}

MAXRADIUS is 32*FRACUNIT.

[Edward-san]

Uh, I read that in zdoom code there is 'self->z +=(-=) 32*FRACBITS;'. Shouldn't it be 'self->z +=(-=) 32*FRACUNIT'?

[Graf Zahl]

Good find. That's of course the problem here.

[Enjay]

Ahhh, much better, thank you.

Of course they still don't appear near where the sprite would indicate but that's not ZDoom's fault. However, with them now appearing a bit higher in ZDoom, it is easier for me to modify the shots in DECORATE with a less severe change so they look better but their behaviour isn't affected too badly.