[r3245+] Powerup.Colormap broken

[Gez]

The colormap code refactoring resulted in the default colormap initialization being moved from InitPalette() called by V_Init() to R_InitColormaps() called by R_Init().

The important detail being that V_Init() is called before actors are loaded, but R_Init() is called afterwards.

Since the default colormaps are not yet initialized when actors are parsed, the code in DEFINE_CLASS_PROPERTY_PREFIX(powerup, colormap, FFFfff, Inventory) results in nonsense -- the first will be the inverse map for example. Worse, since R_InitColormaps() starts by cleaning out existing colormaps, it might be possible to have actors using a no-longer existent colormap if you define more of them than there are default colormaps. I haven't actually tried to see what happens then, but it can't be good!

More information on the subject can be found here.