[GZDoom commit 925305a] 3D Floor crash

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
Post Reply
User avatar
Ryan Cordell
Posts: 4349
Joined: Sun Feb 06, 2005 6:39 am
Preferred Pronouns: No Preference
Operating System Version (Optional): Windows 10
Graphics Processor: nVidia (Modern GZDoom)
Location: Capital of Explodistan

[GZDoom commit 925305a] 3D Floor crash

Post by Ryan Cordell »

For whatever reason, this recent commit https://github.com/coelckers/gzdoom/com ... 497ec4b9f9 for updating the vertex dirty states ends up crashing GZDoom hard whenever it encounters a map with 3D floors, such as DoomRPGs Outpost (a more innocent crash) or, even worse, Stronghold (a heap error!). Tested on a clean build, both me and Edward850 can confirm it's happened to both of us.
User avatar
everamzah
Posts: 149
Joined: Tue Aug 20, 2013 10:17 am
Location: Augusta, ME.
Contact:

Re: [GZDoom commit 925305a] 3D Floor crash

Post by everamzah »

Same here.
User avatar
Kyle873
Posts: 667
Joined: Thu Jun 28, 2012 11:48 am
Location: Ontario, Canada

Re: [GZDoom commit 925305a] 3D Floor crash

Post by Kyle873 »

Can also confirm this.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49056
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: [GZDoom commit 925305a] 3D Floor crash

Post by Graf Zahl »

I wasn't able to reproduce this with any map I tested, but there was definitely something wrong here. The dirty setting was called in some places where it shouldn't, in particular from the map init code where not everything was properly set up yet.
User avatar
everamzah
Posts: 149
Joined: Tue Aug 20, 2013 10:17 am
Location: Augusta, ME.
Contact:

Re: [GZDoom commit 925305a] 3D Floor crash

Post by everamzah »

Did the map you tried testing with have 3D floors? Specifically Sector_Set3dFloor?
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49056
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: [GZDoom commit 925305a] 3D Floor crash

Post by Graf Zahl »

Yes, I used Enjay's Burghead mod.
User avatar
everamzah
Posts: 149
Joined: Tue Aug 20, 2013 10:17 am
Location: Augusta, ME.
Contact:

Re: [GZDoom commit 925305a] 3D Floor crash

Post by everamzah »

I couldn't find Enjay's Burghead mod. I made a simple test map and it crashes here. https://www.dropbox.com/s/a6o9m8cxllpk39l/160test.wad
User avatar
Ed the Bat
Posts: 3060
Joined: Thu May 03, 2012 1:18 pm
Graphics Processor: nVidia with Vulkan support
Location: Maryland, US
Contact:

Re: [GZDoom commit 925305a] 3D Floor crash

Post by Ed the Bat »

everamzah wrote:I couldn't find Enjay's Burghead mod.
http://www.doomworld.com/idgames/index. ... bgpabh.zip
User avatar
everamzah
Posts: 149
Joined: Tue Aug 20, 2013 10:17 am
Location: Augusta, ME.
Contact:

Re: [GZDoom commit 925305a] 3D Floor crash

Post by everamzah »

Is it because of the map format? UDMF vs. Hexen format for example?
Image
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49056
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: [GZDoom commit 925305a] 3D Floor crash

Post by Graf Zahl »

fixed.

The hard crash was indeed UDMF only and my last commit already fixed it.
The heap corruption, though, had nothing to do with 3D floors, it was just random chance that you discovered it only in these maps.
Post Reply

Return to “Closed Bugs [GZDoom]”