[GZDoom commit 925305a] 3D Floor crash
Moderator: GZDoom Developers
Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
- Ryan Cordell
- Posts: 4349
- Joined: Sun Feb 06, 2005 6:39 am
- Preferred Pronouns: No Preference
- Operating System Version (Optional): Windows 10
- Graphics Processor: nVidia (Modern GZDoom)
- Location: Capital of Explodistan
[GZDoom commit 925305a] 3D Floor crash
For whatever reason, this recent commit https://github.com/coelckers/gzdoom/com ... 497ec4b9f9 for updating the vertex dirty states ends up crashing GZDoom hard whenever it encounters a map with 3D floors, such as DoomRPGs Outpost (a more innocent crash) or, even worse, Stronghold (a heap error!). Tested on a clean build, both me and Edward850 can confirm it's happened to both of us.
Re: [GZDoom commit 925305a] 3D Floor crash
Same here.
Re: [GZDoom commit 925305a] 3D Floor crash
Can also confirm this.
- Graf Zahl
- Lead GZDoom+Raze Developer
- Posts: 49056
- Joined: Sat Jul 19, 2003 10:19 am
- Location: Germany
Re: [GZDoom commit 925305a] 3D Floor crash
I wasn't able to reproduce this with any map I tested, but there was definitely something wrong here. The dirty setting was called in some places where it shouldn't, in particular from the map init code where not everything was properly set up yet.
Re: [GZDoom commit 925305a] 3D Floor crash
Did the map you tried testing with have 3D floors? Specifically Sector_Set3dFloor?
- Graf Zahl
- Lead GZDoom+Raze Developer
- Posts: 49056
- Joined: Sat Jul 19, 2003 10:19 am
- Location: Germany
Re: [GZDoom commit 925305a] 3D Floor crash
Yes, I used Enjay's Burghead mod.
Re: [GZDoom commit 925305a] 3D Floor crash
I couldn't find Enjay's Burghead mod. I made a simple test map and it crashes here. https://www.dropbox.com/s/a6o9m8cxllpk39l/160test.wad
- Ed the Bat
- Posts: 3060
- Joined: Thu May 03, 2012 1:18 pm
- Graphics Processor: nVidia with Vulkan support
- Location: Maryland, US
- Contact:
Re: [GZDoom commit 925305a] 3D Floor crash
http://www.doomworld.com/idgames/index. ... bgpabh.zipeveramzah wrote:I couldn't find Enjay's Burghead mod.
- Graf Zahl
- Lead GZDoom+Raze Developer
- Posts: 49056
- Joined: Sat Jul 19, 2003 10:19 am
- Location: Germany
Re: [GZDoom commit 925305a] 3D Floor crash
fixed.
The hard crash was indeed UDMF only and my last commit already fixed it.
The heap corruption, though, had nothing to do with 3D floors, it was just random chance that you discovered it only in these maps.
The hard crash was indeed UDMF only and my last commit already fixed it.
The heap corruption, though, had nothing to do with 3D floors, it was just random chance that you discovered it only in these maps.