[r2819/r974] KEYCONF & LANGUAGE bugs

[The Ultimate DooMer]

When trying this version (or presumably any with the new menu code) my custom keybinds got wiped. Looking at the controls menu, I saw that only the first keysection was being displayed, the menu keys from the other sections were all lumped into this one and had lost all keybinds. Looking in the .ini also confirmed that replacing any of the lost keybinds (ie. the ones from the other keysections) were added to the first one instead.

---

Code: Select all

clearplayerclasses
addplayerclass Anvar
addplayerclass Braxus
addplayerclass Sallazar

addkeysection "weapons" serpent_weaponsection

alias weapon_1 "slot 1"
alias weapon_2 "slot 2"
alias weapon_3 "slot 3"
alias weapon_4 "slot 4"
alias weapon_5 "slot 5"
alias weapon_6 "slot 6"
alias weapon_7 "slot 7"
alias weapon_8 "slot 8"
addmenukey "weapon 1" weapon_1
addmenukey "weapon 2" weapon_2
addmenukey "weapon 3" weapon_3
addmenukey "weapon 4" weapon_4
addmenukey "weapon 5" weapon_5
addmenukey "weapon 6" weapon_6
addmenukey "weapon 7" weapon_7
addmenukey "weapon 8" weapon_8

addkeysection "role-playing functions" serpent_rpgsection

alias menu "puke 411"
alias cursor_down "puke 415"
alias cursor_up "puke 416"
alias attribute_raise "puke 417"
addmenukey "toggle rpg menu" menu
addmenukey "move cursor down" cursor_down
addmenukey "move cursor up" cursor_up
addmenukey "raise attribute" attribute_raise

addkeysection "item hotkeys" serpent_itemsection

alias use_potionoflife "use potionoflife"
alias use_potionofwaterbreathing "use potionofwaterbreathing"
alias use_potionoffireprotection "use potionoffireprotection"
alias use_jumpboots "use jumpboots"
alias use_speedboots "use speedboots"
alias use_toorch "use toorch"
alias use_poisonvial "use poisonvial"
alias use_timebomboftheancients "use timebomboftheancients"
alias use_discofrepulsion "use discofrepulsion"
alias use_porkalator "use porkalator"
alias use_forcestone "use forcestone"
alias use_sirenorb "use sirenorbitem"
addmenukey "potion of life" use_potionoflife
addmenukey "potion of water breathing" use_potionofwaterbreathing
addmenukey "potion of fire protection" use_potionoffireprotection
addmenukey "jump boots" use_jumpboots
addmenukey "speed boots" use_speedboots
addmenukey "torch" use_toorch
addmenukey "poison vial" use_poisonvial
addmenukey "timebomb of the ancients" use_timebomboftheancients
addmenukey "disc of repulsion" use_discofrepulsion
addmenukey "porkalator" use_porkalator
addmenukey "force stone" use_forcestone
addmenukey "siren orb" use_sirenorb

addkeysection "mana hotkeys" serpent_manasection

alias use_mana11battery "use mana11battery"
alias use_mana22battery "use mana22battery"
alias use_mana33battery "use mana33battery"
alias use_mana44battery "use mana44battery"
alias use_kraterofmight "use kraterofmight"
addmenukey "blue mana battery" use_mana11battery
addmenukey "green mana battery" use_mana22battery
addmenukey "yellow mana battery" use_mana33battery
addmenukey "red mana battery" use_mana44battery
addmenukey "krater of might" use_kraterofmight

addkeysection "magic hotkeys" serpent_magicsection

alias use_scroll1 "puke 542"
alias use_scroll2 "puke 543"
alias use_scroll3 "puke 544"
alias use_scroll4 "puke 545"
alias use_scroll5 "use scroll5"
alias use_scroll6 "use scroll6"
alias use_scroll7 "use scroll7"
alias use_scroll8 "use scroll8"
alias use_scroll9 "use scroll9"
alias use_scroll0 "use scroll0"
alias use_magicring "use magicring"
addmenukey "power spell" use_scroll1
addmenukey "protection spell" use_scroll2
addmenukey "fear spell" use_scroll3
addmenukey "summon spell" use_scroll4
addmenukey "shrapnel spell" use_scroll5
addmenukey "inferno spell" use_scroll6
addmenukey "penetrate spell" use_scroll7
addmenukey "hellstorm spell" use_scroll8
addmenukey "timestop spell" use_scroll9
addmenukey "annhilation spell" use_scroll0
addmenukey "magic ring" use_magicring

---

http://img4.imageshack.us/i/keyconfmenu.png/

---

Code: Select all

[Hexen.serpent_weaponsection.Bindings]
1=weapon_1
2=weapon_2
3=weapon_3
4=weapon_4
5=weapon_5
6=weapon_6
7=weapon_7
8=weapon_8
kp1=use_scroll1
kp2=use_scroll2
kp3=use_scroll3
kp4=use_scroll4
kp5=use_scroll5
kp6=use_scroll6
kp7=use_scroll7
kp8=use_scroll8
kp9=use_scroll9
kp.=use_scroll0

[Hexen.serpent_weaponsection.DoubleBindings]

[Hexen.serpent_rpgsection.Bindings]
ins=menu
home=cursor_down
pgup=attribute_raise

[Hexen.serpent_rpgsection.DoubleBindings]

[Hexen.serpent_itemsection.Bindings]
enter=use_potionoflife
del=use_poisonvial
end=use_timebomboftheancients
pgdn=use_porkalator

[Hexen.serpent_itemsection.DoubleBindings]

[Hexen.serpent_manasection.Bindings]
kp/=use_mana11battery
kp*=use_mana22battery
kp-=use_mana33battery
kp+=use_mana44battery

[Hexen.serpent_manasection.DoubleBindings]

[Hexen.serpent_magicsection.Bindings]
kp1=use_scroll1
kp2=use_scroll2
kp3=use_scroll3
kp4=use_scroll4
kp5=use_scroll5
kp6=use_scroll6
kp7=use_scroll7
kp8=use_scroll8
kp9=use_scroll9
kp.=use_scroll0
kp0=use_magicring

[Hexen.serpent_magicsection.DoubleBindings]

Edit: It also ignores the playerclasses lines and the corresponding lines in my LANGUAGE lump too...they come up as fighter, cleric and mage instead of the names I defined. (oddly enough it didn't change the entry for "random", "choose class" or any others)

---

Code: Select all

[enu default]

STSTR_DQDON = "God Mode ON";
STSTR_DQDOFF = "God Mode OFF";

MNU_NEWGAME			= "NEW GAME";
MNU_OPTIONS			= "OPTIONS";
MNU_GAMEFILES		= "LOAD/SAVE";
MNU_INFO			= "INFO";
MNU_QUITGAME		= "QUIT GAME";

MNU_FIGHTER			= "ANVAR";
MNU_CLERIC			= "BRAXUS";
MNU_MAGE			= "SALLAZAR";
MNU_RANDOM			= "?";
MNU_CHOOSECLASS		= "CHARACTER:";
MNU_CHOOSESKILL		= "SKILL SETTING:";

MNU_SQUIRE			= "TOURIST";
MNU_KNIGHT			= "EASY";
MNU_WARRIOR			= "NORMAL";
MNU_BERSERKER		= "HARD";
MNU_TITAN			= "HEROIC";
                                    
MNU_ALTARBOY		= "TOURIST";
MNU_ACOLYTE			= "EASY";
MNU_PRIEST			= "NORMAL";
MNU_CARDINAL		= "HARD";
MNU_POPE			= "HEROIC";
                                    
MNU_APPRENTICE		= "TOURIST";
MNU_ENCHANTER		= "EASY";
MNU_SORCERER        = "NORMAL";
MNU_WARLOCK			= "HARD";
MNU_ARCHMAGE		= "HEROIC";

MNU_SKILL1			= "this setting is for those who want to\nsee the world without being challenged.\n\ndo you wish to continue?";
MNU_SKILL2			= "this setting is for those who want an easier ride with little rpg thinking.\n\ndo you wish to continue?";
MNU_SKILL3			= "this setting is for most players\nand those who haven't played before.\n\ndo you wish to continue?";
MNU_SKILL4			= "this setting is for experienced players\nand those who want a more strategic rpg.\n\ndo you wish to continue?";
MNU_SKILL5			= "this setting is for experts only!\n\ndo you wish to continue?";

[Graf Zahl]

Can you slap together a small WAD only containing the relevant data so that I can run some tests?

[The Ultimate DooMer]

menutest.zip

(2.5 KiB) Downloaded 77 times

[Graf Zahl]

fixed. I'm more confused why the compiler did not complain about such a blatant error in the code.

[The Ultimate DooMer]

It's still ignoring my LANGUAGE lump for player class strings, that's only a minor bug though.

[Graf Zahl]

The reason for that is that the language string is no longer used. I merged Hexen's special playerclass menu with the generic one but that uses the players' displaynames.

However, and here lies the problem, Grubber used the 'display'names for purposes other than just displaying them so I have 2 choices now: Either risk breaking a handful of mods or leave it as it is which means that player class displaynames cannot be stringtable references.

[The Ultimate DooMer]

No problem, I added a Player.DisplayName to each class and it's fine now. A couple of other minor things: I've just noticed it's ignoring my M_CWALK1-4 replacements (the animated player display inside the box), and the box disappears altogether when the mouse cursor is not on any of the class names.

(the wiki for the new menu stuff isn't complete yet so I don't know what's meant to work now or how to recreate the menu with the new code)

[Graf Zahl]

I've just noticed it's ignoring my M_CWALK1-4 replacements (the animated player display inside the box), and the box disappears altogether when the mouse cursor is not on any of the class names.

Do your player classes inherit from the original Hexen players? If not, you may have to copy the 'player.portrait' property which is now being used for these animations.

The second part is normal. If no player is selected, none can be shown, right?

[The Ultimate DooMer]

They inherit and replace Fighter/Cleric/MagePlayer. I tried adding the portrait property and I got the plain green box instead of the Hexen one, with the portrait also animating faster. Trying the box instead just gave me the box with no portrait inside.

[Graf Zahl]

Hm, that's odd. When I load your test WAD and add the new display names to the redefinitions I get the portraits in the menu as before.

[The Ultimate DooMer]

That one had no replacement graphics, here's a new one.

(I've added the portrait boxes too, as they're not being overridden by my replacements either)

[Graf Zahl]

No problems with that. I get your replaced animation for the Cleric. It's all as it should be.

[The Ultimate DooMer]

I have it now - in my project, the graphics are in a subfolder inside the pk3...copying them to the root folder (as in the test wad) made them work as normal.

[Graf Zahl]

They should be in the Graphics/ folder.

[The Ultimate DooMer]

That's the subfolder they were in.