[GZDoom Submission]Quake Camera Roll Inclusion

[Blzut3]

I can see this closed with [lol no].

All I can say is, given that the last quake suggestion was drawn out with a "eeehhh, I don't know if we really want more parameters" for the longest time, my only thoughts are "do we really want more parameters?"

[Major Cooke]

Pffft. A_SpawnParticle sets a new record.

Besides, this is GZDoom only. Until, as mentioned, someone happens to make such a thing doable for the software renderer, should that happen anyway.

[Nash]

As Nash's mod demonstrate, it's already possible to control camera roll with a mod. You want explosions to do some camera roll, you mod it in.

I'd just like add a remark to this remark; a good reason to NOT mod it in is because calling A_SetRoll or Set/ChangeActorRoll via scripting or DECORATE actually physically changes the actor's roll. If an effect you want to do is meant to be purely visual (as in, only affecting the viewer's camera and not actual actors in the world)... well, that's not possible. And if you tie your scripted rolls with a GetCvar to control user enable/disable of that stuff, the game will most probably desync in multiplayer.

If anyone wants to do it right and set it up correctly in R_SetupFrame (and as Graf said, maybe in the future someone figures out how to do it in the software renderer), be my guest!

[Graf Zahl]

I can see this closed with [lol no].

All I can say is, given that the last quake suggestion was drawn out with a "eeehhh, I don't know if we really want more parameters" for the longest time, my only thoughts are "do we really want more parameters?"

Structs would be nice, but sadly are beyond DECORATE's capabilities.

[Major Cooke]

I'd just like add a remark to this remark; a good reason to NOT mod it in is because calling A_SetRoll or Set/ChangeActorRoll via scripting or DECORATE actually physically changes the actor's roll. If an effect you want to do is meant to be purely visual (as in, only affecting the viewer's camera and not actual actors in the world)... well, that's not possible. And if you tie your scripted rolls with a GetCvar to control user enable/disable of that stuff, the game will most probably desync in multiplayer.

If anyone wants to do it right and set it up correctly in R_SetupFrame (and as Graf said, maybe in the future someone figures out how to do it in the software renderer), be my guest!

QFT. Seriously. I have no better way of saying this than right here.

@Graf: So how does it check out so far?

[Graf Zahl]

Sorry, no time so far.

[Major Cooke]

Also small question, with all that you've just recently done with GZDoom, am I going to need to change anything? Or will nothing there be intrusive? Just curious, wanted to make sure I'm ready to make any changes on my end if needed.

[Graf Zahl]

No, the code this touches wasn't changed.

[Blue Shadow]

The ACC part of this wasn't merged.

[Major Cooke]

Huh... He's right. It wasn't.