A_RadiusGive Overhaul

[Major Cooke]

Pull Request.

Fixed a lot of things wrong with A_RadiusGive, and added some goodies. See the pull request for more info.

If you're wondering, KILLED != CORPSE at all times. If you want true results of who is truly dead and whose not, use RGF_KILLED.

One thing I forgot to mention in the request is RGF_GIVESELF, the pointer flags and the species processing comes first. RGF_GIVESELF will always succeed now.

[Graf Zahl]

One note:

MF_SPECIAL is NOT the same as being an inventory item. Strife's Spectres also use this flag.

[Major Cooke]

Fixing now.

[NeuralStunner]

Seems like you'd have to check the inheritance chain.

[Major Cooke]

Only reason to do that is for state jumps, I think.

Graf: Fixed. No longer uses MF_SPECIAL, now uses thing->IsKindOf(RUNTIME_CLASS(AInventory)) instead.

[Beed28]

Amazing! You truly are the best!

Can map-wide radiuses work reliably now, as well?

[Major Cooke]

They were working fine for me to begin with.

And, I'm not the best. Once they pointed out that it was flawed logic, the problem was much easier to fix than thought.

[Graf Zahl]

Merged, although I'll freely admit that I only superficially reviewed the code - it can only get better from what was there...

[Major Cooke]

You can always tell me how I can improve upon it and I'll do my best to do so.

I had the uneasy feeling that a bunch of booleans would be frowned upon, but I didn't want to make as much of a mess.

[Xtyfe]

Oh wow, this is very useful for me. Thanks for fixing it up

[Major Cooke]

Not a problem! I've updated the wiki too.

It should be noted I didn't touch the radius code. I'm going nowhere near it as I'm rather horrible at that kind of thing.

[NeuralStunner]

thing->IsKindOf(RUNTIME_CLASS(AInventory))

Oh right, I forgot you could do this. Nevermind me.