[2.6.0?] snd_reset no longer restarts music after stopmus

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
Post Reply
zalewa
Posts: 14
Joined: Sun Dec 03, 2006 5:50 pm

[2.6.0?] snd_reset no longer restarts music after stopmus

Post by zalewa »

I've noticed that newest beta Zandronum builds (which are based off ZDoom 2.8) no longer restart level music on snd_reset CCMD when it was first stopped with stopmus CCMD. I've found this commit that seems to introduce the change:
https://github.com/rheit/zdoom/commit/a ... 9ab452d302

Was this side effect intentional? The commit message only states that this was supposed to affect volume changes in the menu.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49234
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: [2.6.0?] snd_reset no longer restarts music after stopmu

Post by Graf Zahl »

Of course this was intentional. That was the whole point of this change. If the music was explicitly stopped it should not automatically resume.
zalewa
Posts: 14
Joined: Sun Dec 03, 2006 5:50 pm

Re: [2.6.0?] snd_reset no longer restarts music after stopmu

Post by zalewa »

One could argue that calling snd_reset CCMD isn't automatic but intentional, but it doesn't matter anymore as music restart can also be achieved with 'changemus *'.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49234
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: [2.6.0?] snd_reset no longer restarts music after stopmu

Post by Graf Zahl »

The point here is that 'stopmus' must clear the active music. And once it's cleared, even a snd_reset shouldn't restart it - because there was no music playing at the time of reset.
zalewa
Posts: 14
Joined: Sun Dec 03, 2006 5:50 pm

Re: [2.6.0?] snd_reset no longer restarts music after stopmu

Post by zalewa »

That is... logical.
Post Reply

Return to “Closed Bugs [GZDoom]”