[zdoom-2.8pre-780] crash: actor hits floor thing

[WaTaKiD]

originally reported here: https://zandronum.com/tracker/view.php?id=0001985 (additional info in the notes)

falling onto a sector with an 'actor hits floor' thing that teleports you will crash instead, and the crash does not bring up the 'save crash report' box

with the example wad provided:
walk forward, u should teleport just fine
once u teleport, jump, and u should crash


as this is my first bug report here, i apologize if i did anything incorrectly

[edward850]

[Don't do that]. You are teleporting the player into a sector that also teleports the player into a sector that also teleports the player into a sector that also teleports the player into a sector that also teleports the player into a sector that also teleports the player into a sector that also teleports the player into a sector that also teleports the player into a sector that also teleports the player into a sector that also teleports the player into a sector that also teleports the player into a sector that also teleports the player into a sector that also teleports the player into a sector that also teleports the player into a sector that also teleports...

Eventually Windows kills it because ZDoom's callstack fills up or you run out of memory from your infinite teleport hoedown.

Specifically, landing on the floor will transfer that subsequent call to any other floor you "land on" from being teleported. This is intended behaviour. You need to assign a script to handle the teleporters properly.

[Graf Zahl]

I think the rules for 'actor hits floor' are stupid and too general, this really shouldn't trigger if a sector is entered by teleporting. This was just one of those stupid things that got reported as a bug and Randi dilligently changed it without thinking about the consequences. In any case, recursive teleports, like what happens in this setup are a surefire way to crash the engine, there's not much that can be done about it other than delaying the teleport with a script.

[StrikerMan780]

So, just for clarification... It'll screw up and crash no matter where you teleport? Even if you teleport to another sector the DOES NOT have an "Actor Hits Floor" actor?

Then again, even if it did have another "Actor Hits Floor" actor like was said... it really shouldn't trigger if entered by teleporting (Unless you teleport in from a Z-Position Higher than Zero, perhaps that condition could be used?). What if this was changed? I don't foresee anything relying on this screwy behavior... Really should be fixed for better or worse.

[edward850]

So, just for clarification... It'll screw up and crash no matter where you teleport? Even if you teleport to another sector the DOES NOT have an "Actor Hits Floor" actor?

What... why would that ever... what? Where do you people get these ideas?
No, it's crashing because the sector being teleported into is triggering a sector action that teleports to another sector that triggers a sector action that teleports to another sector that triggers a sector action that teleports to another sector that triggers a sector action that teleports to another sector that triggers a sector action that teleports to another sector that triggers a sector action that teleports to another sector that triggers a sector action that teleports to another sector that triggers a sector action that teleports to another sector that triggers a sector action that teleports to another sector that triggers a sector action that teleports to another sector that triggers a sector action that teleports to another sector that triggers a sector action...

It was changed to this behaviour because other sector actions weren't being triggered in new sectors, without the foresight that it can be mistakenly erroneous. Various maps actually expect sector actions to trigger on such movement.

[StrikerMan780]

No need to be an asshole about it. A simple "No, only when you teleport to another sector with an actor hits floor that teleports you back to the first." would have sufficed.

I got that idea because of this: "Specifically, landing on the floor will transfer that subsequent call to any other floor you "land on" from being teleported."
Which was kind of confusing and I just asked for clarification. Geez. Because the way that was worded made it seem the special was being transferred to the floor of the sector you were being teleported to. (Which, to me, would be a very easy culprit for infinite recursion)

Also, nice to see the rest of my post completely ignored for the sake of finding an excuse to be a smartass:

Then again, even if it did have another "Actor Hits Floor" actor like was said... it really shouldn't trigger if entered by teleporting (Unless you teleport in from a Z-Position Higher than Zero, perhaps that condition could be used?). What if this was changed? I don't foresee anything relying on this screwy behavior... Really should be fixed for better or worse.

I stated the above because I thought it was perhaps more accurate to what's going on, and from what I can tell, is correct.

[edward850]

Maybe if you actually heeded your own advice and read posts:

Then again, even if it did have another "Actor Hits Floor" actor like was said... it really shouldn't trigger if entered by teleporting (Unless you teleport in from a Z-Position Higher than Zero, perhaps that condition could be used?). What if this was changed? I don't foresee anything relying on this screwy behavior... Really should be fixed for better or worse.

And behold:

I think the rules for 'actor hits floor' are stupid and too general, this really shouldn't trigger if a sector is entered by teleporting. This was just one of those stupid things that got reported as a bug and Randi dilligently changed it without thinking about the consequences.

It was changed to this behaviour because other sector actions weren't being triggered in new sectors, without the foresight that it can be mistakenly erroneous. Various maps actually expect sector actions to trigger on such movement.

And of course I got annoyed with your question. You neither read nor thought about what you were saying, and came up with an utterly baseless question as a result.

[StrikerMan780]

If I hadn't of thought about it, I wouldn't have asked any questions, genius.

And I already read those two posts by then, why do you think I suggested the Z-Position thing?

[Graf Zahl]

If you can't act like civilized people...