Rampage Face Error

[Ed the Bat]

I'm not entirely sure when this started, but recently a bug cropped up with the HUD mugshot. In vanilla Doom (and in ZDoom until recently), the mugshot would change to the rampage face when the fire button was held down for a certain length of time. Now, it happens automatically if the animation of a weapon takes this much time, regardless of if the player is holding the trigger. Example attached below:

[Blzut3]

It was actually a bug that caused the face to only take into account if the button was held or not. In vanilla (and IIRC pre-sbarinfo versions of ZDoom) the rampage face wouldn't disappear until the attack animation finished and the button was not held at that particular moment.

This meant that in ZDoom if you aren't the kind to hold down the button when using a weapon like the SSG you'd never see the rampage face (something I couldn't stop noticing once someone on Doom World pointed out the difference). Apparently some people also use the rampage face to tell if their timing on chain gun tapping is correct.

I'm not sure if there's anything I can do for you.

[Ed the Bat]

That's disappointing... a lot of guns with long animations, for cooldowns and such, are making the mugshot get angry when I see no reason for it to. =/

[Blzut3]

Here are the commits in question.

I guess one possible solution would be to add a flag to A_WeaponReady to clear the rampage face (provided the buttons are no longer held). Would that work for your use case?

[Ed the Bat]

I imagine that would work just fine for my purposes. Can't speak for others; a LOT of custom weapons over the years have had animations longer than this threshold.

It's really a fairly small issue, on the whole... I mean, if this new behavior is decidedly the correct way, then I guess I can just live with it.