[r3592] Script 1 forgets its flags

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
Post Reply
User avatar
Nightfall
Posts: 555
Joined: Thu Aug 06, 2009 4:00 am
Location: Finland

[r3592] Script 1 forgets its flags

Post by Nightfall »

Example wad here as per unknownna.

When script flags are loaded, the max variable is set to scripts.dw[1] and not to scripts.dw[1] / 4 like the var count lister.
A consequence of this is that the flags reader gets garbage entries, setting the script 1's flags to 0 (should be NET CLIENTSIDE) in the process.

If you sneak a debugline

Code: Select all

Printf ("Setting flags of %d to %d.\n", scripts.sw[0], scripts.w[1]);
after

Code: Select all

ptr->Flags = LittleShort(scripts.w[1]);
, you should be getting output like this:
Setting flags of 1 to 3.
Setting flags of 2 to 2.
Setting flags of 1 to 0.
The third line indicates the engine resetting script 1's flags.

In short, r3352 fixed this problem for var counts. Script flags need similar treatment.
User avatar
randi
Site Admin
Posts: 7749
Joined: Wed Jul 09, 2003 10:30 pm
Contact:

Re: [r3592] Script 1 forgets its flags

Post by randi »

Oh, grrk. When I fixed it for SVCT, I thought I looked for other instances where I made the same mistake. Clearly, I missed this one. Hopefully there aren't others I missed too.
Post Reply

Return to “Closed Bugs [GZDoom]”