[?-r3263] Things respawn with incorrect z-position

[unknownna]

http://dev.skulltag.net/tracker/view.php?id=408

• thing_z_misprediction_test_01.wad

Code: Select all

Steps to reproduce:

1. Start ZDoom with the example WAD loaded.
2. "sv_itemrespawn 1" in the console.
3. Pick up the chaingun.
4. The chaingun will respawn into the floor.

* The chaingun still respawns into the wrong position. But this also happens offline and in GZDoom 323. If you reconnect, it corrects itself. Most servers have sv_weaponstay set to 1 anyway.

This sounds like there is an underlying ZDoom problem that needs to be fixed (or at least understood) first. I'm not even sure if the behavior of items that are exactly on a linedef is defined, i.e. in which of the two adjacent sectors is the item supposed to be?

Offline:

* When the z-position is 16, the thing uses the higher floor value as its base.
* When the z-position is 0, the thing uses the higher floor value as its base.

Online:

* When the z-position is 16, the thing uses the lower floor value as its base.
* When the z-position is 0, the thing uses the higher floor value as its base.

First let me say that as far as I can say the only difference between the online and offline behavior is where the client displays the weapon. The actual position on the server should be the same online and offline. Actually, the client even spawns the weapon at the correct position, but it thinks that it is in the lower sector and thus on the client the weapon falls down to the lower sector's height.

Furthermore, the offline behavior for the initial spawn and respawning is different even in ZDoom and I'm pretty sure that this ZDoom problem also causes the client side display problem. So it's not really a good idea to find a solution for the client side display problem without resolving the ZDoom issue first.

Can somebody check if this also happens in the latest ZDoom version and if so, make a bug report over there?

* The chaingun doesn't respawn into the floor in ZDaemon 1.08.08b.
* The chaingun doesn't respawn into the floor in Odamex 0.5.3.
* The chaingun respawns into the floor in GZDoom 323.
* The chaingun respawns into the floor in ZDoom 2.5.0.
* The chaingun respawns into the floor in ZDoom SVN build 3263.

[unknownna]

* The chaingun doesn't respawn into the floor in ZDaemon 1.08.08b.
* The chaingun doesn't respawn into the floor in Odamex 0.5.3.
* The chaingun respawns into the floor in GZDoom 323.
* The chaingun respawns into the floor in ZDoom 2.5.0.
* The chaingun respawns into the floor in ZDoom SVN build 3263.

* The chaingun doesn't respawn into the floor in Chocolate Doom 1.6.0.

[randi]

Fixed.

[unknownna]

Monsters still respawn (sv_monsterrespawn 1) into foul positions. You can verify this in MAP01. Let the zombieman on the right respawn.

[randi]

Fixed.

[Edward-san]

Why did you comment out the pr_nightmarerespawn call?

[unknownna]

Why did you comment out the pr_nightmarerespawn call?

Indeed.

Hmm, does anybody know whether he intentionally commented out pr_nightmarerespawn?

[randi]

I'm surprised this would be open to interpretation. Yes, I intentionally commented it out so monsters would respawn sooner. No, that change was not supposed to find its way into the repository.