[r3130-r3154]debug build problem with assertion + stronghold

[Edward-san]

Hi, I've encountered a problem with the debug build, here there're the steps:
1)Load strnghld_v1.pk3 in zdoom;
2)start a game with whatever skill;
3)skip the introduction;
4)at map99, go forward as you want to go to the big area;

then the program exits with this error:

Code: Select all

zdoom: /home/edward-san/zdoom/workcopy/src/r_segs.cpp:484: void R_RenderMaskedSegRange(drawseg_t*, int, int): Assertion `ds->bkup >= 0' failed.
Aborted

It doesn't happen in release build.

[randi]

I added that assert because of this. Rest assured that it is trashing memory in a release build, even if it's not bad enough to crash it. Since I am not familiar with this code, I do not know the proper fix. If I can mature the 3dfloors3 branch, this will be a non-issue. If I can't, this is basically a deal-breaker for software 3D floors.

[Gez]

Kgsws proposed a patch to fix this bug.

[Edward-san]

Indeed that patch fixed this.

The (maybe) surprising thing is that map99 is very slow in debug mode, not in release mode.
It happens also in the unmodified build.

[Gez]

Debug builds are supposed to be slower, since they do more checks and more logging to help, well, debug.

If release builds were slower than debug builds, you'd use debug builds for release, since they'd be faster.

[Edward-san]

I knew that, but I never imagined so much drop from debug build... (i mean from 30-40 fps to 1-2 fps )

[Edward-san]

uhm... [Fixed]?