SourceGuardianDetonator causes CTD when exploding

[scalliano]

As the title suggests, a fatal glitch found by doomer001002123 while playing Shuffle affecting the more recent builds of both ZDoom and GZDoom. Tested it with UTnT and even a clean copy of the monster .WAD from R667 and the same thing happens. Not entirely sure how far this goes back, but my main GZDoom folder uses a build from 31/07/14 with no issues.

Can't see anything wrong with the DECORATE from this end (not my work), so I'm pretty sure it's an engine change that's causing this.

[Enjay]

Comment out the A_Die at the end of the death sequence and the crash stops. No idea why you would need that pointer at the end of the death sequence.

Presumably the pointer is setting the missile back to the start of its death sequence. There are 0 tics of frames between the first call to A_Die and the start of the death sequence.

Code: Select all

  Death:
    SDFB B 0 A_CustomMissile("CatharsiBall", 4, 2, 0)
    SDFB B 0 A_CustomMissile("CatharsiBall", 4, 2, 20)
    SDFB B 0 A_CustomMissile("CatharsiBall", 4, 2, 40)
    SDFB B 0 A_CustomMissile("CatharsiBall", 4, 2, 60)
    SDFB B 0 A_CustomMissile("CatharsiBall", 4, 2, 80)
    SDFB B 0 A_CustomMissile("CatharsiBall", 4, 2, 100)
    SDFB B 0 A_CustomMissile("CatharsiBall", 4, 2, 120)
    SDFB B 0 A_CustomMissile("CatharsiBall", 4, 2, 140)
    SDFB B 0 A_CustomMissile("CatharsiBall", 4, 2, 160)
    SDFB B 0 A_CustomMissile("CatharsiBall", 4, 2, 180)
    SDFB B 0 A_CustomMissile("CatharsiBall", 4, 2, 200)
    SDFB B 0 A_CustomMissile("CatharsiBall", 4, 2, 220)
    SDFB B 0 A_CustomMissile("CatharsiBall", 4, 2, 240)
    SDFB B 0 A_CustomMissile("CatharsiBall", 4, 2, 260)
    SDFB B 0 A_CustomMissile("CatharsiBall", 4, 2, 280)
    SDFB B 0 A_CustomMissile("CatharsiBall", 4, 2, 300)
    SDFB B 0 A_CustomMissile("CatharsiBall", 4, 2, 320)
    SDFB B 0 A_CustomMissile("CatharsiBall", 4, 2, 340)
    SDFB BCDE 6 BRIGHT A_Die
    Stop

As a point of note, the last line of the Spawn sequence also looks like the A_Die line above. I'm not convinced that will be doing what the author intended either.

[Blue Shadow]

That detonator actor definitely needs fixing, in my opinion. It wasn't much of an issue before, because A_Die didn't work on missiles, but it does now.

[Graf Zahl]

A clear case of user error.

[scalliano]

No idea why you would need that pointer at the end of the death sequence.

Apparently to play the actor's "death" sound. I replaced it with:

Code: Select all

A_PlaySound ("catharsi/shotdth") 

and it works perfectly. I'll post the fixes to R667 shortly.

[Ed the Bat]

I'd better make sure to match this change in my revised version of UTnT.