+MTHRUSPECIES on puffs

[Leonard2]

Title says it all.
Let's say we put +THRUSPECIES on a player class so that people can go through each other in a multiplayer game, we could then put +MTHRUSPECIES on rockets, BFG balls and plasma but what about hitscan attacks ?
It's annoying to get pushed randomly by someone in multiplayer.
If the M in the MTHRUSPECIES flag is a problem we could still make a new flag called HTHRUSPECIES or PTHRUSPECIES.

[Leonard2]

Sorry I went ahead and bumped this thread. I hope I won't get any death threat for that.
As already stated this would be incredibly useful for multiplayer, not just for zdoom but if backported to zandronum I can guarantee you everyone will be thankful.
The example can also apply to hitscan monsters that have the +THRUSPECIES flag on and should be as useful as the +MTHRUSPECIES flag already is.

Now I'll be hiding in that corner over here

[Leonard2]

Finally yesterday I got the courage to install Visual Studio and all the required stuff and somehow managed to make my pull request too damn you git!
If the commit is somehow bad please say how so and don't be harsh. I had zero c++ knowledge yesterday and the only experience I had was from ACS.

I fully tested this feature. All 4 cases for the puff : nothing, +thrughost, +mthruspecies, and finally both.
And of course all on the 4 cases for an actor: nothing, spectral, ghost and same species.
All worked perfectly fine.

[Graf Zahl]

Nothing against your pull request - the code sure does what is advertised - but I ask myself it it wouldn't be better to streamline it a bit by passing info about the needed checks to a single callback function instead of endlessly inflating their amount for each new property that needs to get added.

So you'll have to wait a bit longer so I can think about it.

[Leonard2]

I like a challenge.
I hope I made the pull request correctly. GitHub is so confusing.
It took more time to make a pull request than the actual changes.
Again tested with all the possibilies.
You were right it looks much cleaner like that.

EDIT: Damn it git. The new request now has the 2 commits even though I made the last one on a different branch.
And somehow you can't see the changes so you have to look at the raw file.
Sorry.

[Graf Zahl]

Don't worry, it all merged fine. But did you somehow trigger MSVC's auto-format for p_map.cpp? Looks like it, because all the whitespace has been reformatted.