Page 1 of 1

Please add support for the new freedoom IWAD filenames

Posted: Tue Jan 14, 2014 6:19 pm
by funduke
Please add support for the new freedoom IWAD filenames.


http://www.doomworld.com/vb/freedoom/66 ... wad-names/ :
[quote]The IWAD filenames that source ports should recognize are:
freedoom1.wad - official name, "Freedoom: Phase 1"
freedoom2.wad - official name, "Freedoom: Phase 2"
freedm.wad - official name, "FreeDM"[/quote}

Please check also that thread:
http://www.doomworld.com/vb/freedoom/66 ... oms-iwads/

Greetings
Funduke

Re: Please add support for the new freedoom IWAD filenames

Posted: Wed Jan 15, 2014 2:13 am
by Gez
freedoom1 and freedm are already recognized; all that's needed is to add freedoom2 as an alias. Also update the titles I suppose.

Re: Please add support for the new freedoom IWAD filenames

Posted: Wed Jan 15, 2014 3:42 pm
by Ed the Bat
Gez wrote:Also update the titles I suppose.
This would actually be simple to do on the other end (as in, Freedoom could do it themselves, without involvement of ZDoom devs) if custom titles were allowed in IWADs. I understand GAMEINFO lumps are skipped because of a risk of other problems, due to load order and such, but I often wonder if a watered-down or 'lite' alternative to GAMEINFO lumps could be offered for IWADs, specifically for non-volatile functions such as custom titlebars.

Re: Please add support for the new freedoom IWAD filenames

Posted: Wed Jan 15, 2014 3:46 pm
by Gez
I think it's a missing feature more than a security measure. 1. Load GAMEINFO lumps from file list, 2. select IWAD from said GAMEINFO lumps if available or display selector box otherwise, 3. load GAMEINFO from IWAD but ignoring (of course) the IWAD key as well as any GAMEINFO key that have already been defined.

Re: Please add support for the new freedoom IWAD filenames

Posted: Wed Jan 15, 2014 3:50 pm
by Ed the Bat
I know IWAD GAMEINFO support has been suggested multiple times in the past, and the replies Graf gave to them made it seem like it was not going to be possible to offer these options.

http://forum.zdoom.org/viewtopic.php?f=15&t=33931
Graf Zahl wrote:It's still not a bug. The way this lump is handled it can't be used from IWADs.

Re: Please add support for the new freedoom IWAD filenames

Posted: Thu Jan 16, 2014 12:02 pm
by NeuralStunner
I'm not sure why the game title at the least can't be loaded from the IWad. By the time you're seeing the title, everything (IWad, mods) is already in the loading phase.

Re: Please add support for the new freedoom IWAD filenames

Posted: Sat Jan 18, 2014 1:54 am
by Xaser
Ed the Bat wrote:I know IWAD GAMEINFO support has been suggested multiple times in the past, and the replies Graf gave to them made it seem like it was not going to be possible to offer these options.
Not possible? How? Doesn't the rest of the discussion make it clear that it's just a missing feature someone needs to come along and write?

To clarify something, though, the linked thread was closed but then re-opened later, which is a sign that points to feasibility.

Re: Please add support for the new freedoom IWAD filenames

Posted: Sat Jan 18, 2014 5:42 am
by Graf Zahl
GAMEINFO, as implemented is a pure PWAD feature. Of course this doesn't mean that some stuff from it cannot be transferred to an IWAD feature.

Re: Please add support for the new freedoom IWAD filenames

Posted: Sun Jan 19, 2014 1:47 am
by fraggle
If support can be added for IWADs to include a GAMEINFO lump identifying themselves then I'd be happy to add one to Freedoom.

For now we'd just like to see the IWAD files recognized as valid IWADs though.

Re: Please add support for the new freedoom IWAD filenames

Posted: Sun Jan 19, 2014 7:23 am
by Graf Zahl
Could be done, of course. It would only affect the startup window's banner, though. For autodetection, ZDoom needs an entry in its IWADINFO because it's not feasible to scan all WADs it finds in the IWAD search path. Therefore, for Freedoom, which will get its IWADINFO entry anyway it makes little sense to add such a thing to the WAD itself.

Re: Please add support for the new freedoom IWAD filenames

Posted: Mon Feb 17, 2014 5:42 pm
by Gez
Since it was literally 10 seconds' work, have a pull request.

Re: Please add support for the new freedoom IWAD filenames

Posted: Tue Feb 18, 2014 12:51 pm
by funduke
Thank you!

:D

Greetings
Funduke