Page 1 of 1

Remove doom_sbar.cpp

Posted: Mon Dec 01, 2008 4:11 pm
by Blzut3
As far as I am aware the SBarInfo implementation of the Doom status bar and its ZDoom HUD is accurate. If this patch is applied be sure to delete src/g_doom/doom_sbar.cpp.
doomsbar.zip
The Heretic HUD is almost possible, but a small question on that. Would including an animdefs entry for the health icon be acceptable?

Re: Remove doom_sbar.cpp

Posted: Mon Dec 01, 2008 5:07 pm
by Graf Zahl
Sure. It's not the first HUD/statusbar icon that has. The rotating powerup icons also use such animations.

Re: Remove doom_sbar.cpp

Posted: Mon Dec 01, 2008 5:19 pm
by randi
I don't know about this. The native status bar is still faster than SBARINFO when done with software rendering, since it doesn't redraw everything every frame. It's not so much an issue with Windows any more, but it certainly is with Linux.

Re: Remove doom_sbar.cpp

Posted: Mon Dec 01, 2008 5:40 pm
by Graf Zahl
The irony being that this patch was done by a Linux user... ;)


I won't commit today though so if someone who can test says it's a bad idea I'll revert this patch before committing.

Re: Remove doom_sbar.cpp

Posted: Mon Dec 01, 2008 6:00 pm
by Blzut3
randy wrote:It's not so much an issue with Windows any more, but it certainly is with Linux.
I don't notice any problems performance wise, but of course I am using a Q6600 processor.

Re: Remove doom_sbar.cpp

Posted: Mon Dec 01, 2008 8:37 pm
by randi
Does SBARINFO respect the hud_scale cvar?

Re: Remove doom_sbar.cpp

Posted: Mon Dec 01, 2008 8:41 pm
by Blzut3
Yes. It also shifts the upper right quadrant when vid_fps is enabled just like before.

Re: Remove doom_sbar.cpp

Posted: Tue Dec 02, 2008 5:34 pm
by Graf Zahl
Any decision?

Re: Remove doom_sbar.cpp

Posted: Fri Dec 05, 2008 5:07 pm
by Blzut3
I got around to testing on a slower coputer IBM TP T22: Pentium 3 900mhz I think.

320x200
With doom_sbar.cpp: ~122fps
Without doom_sbar.cpp: ~114fps

640x480
With doom_sbar.cpp: ~36fps
Without doom_sbar.cpp: ~35fps

I don't think sbarinfo is going to cause a whole lot of trouble for Linux users.

Re: Remove doom_sbar.cpp

Posted: Fri Dec 05, 2008 5:11 pm
by Graf Zahl
You call that slow? Wait until Leileilol does such a comparison on his 486... :mrgreen:


(Obviously, I doubt that the relative difference will be more significant there... ;))


One question though: Was the second comparison with a scaled or unscaled statusbar?

Re: Remove doom_sbar.cpp

Posted: Fri Dec 05, 2008 5:25 pm
by Blzut3
Scaled I think. (That's is the default correct?)

And I call it slower than a Core 2. ;)

Re: Remove doom_sbar.cpp

Posted: Sat Dec 06, 2008 4:23 am
by Graf Zahl
I committed the change anyway. If someone doesn't like it it it may be reverted.