[Added] Please add support for the new freedoom IWAD filenames

Moderator: Developers

Please add support for the new freedoom IWAD filenames

Postby funduke » Tue Jan 14, 2014 6:19 pm

Please add support for the new freedoom IWAD filenames.


http://www.doomworld.com/vb/freedoom/66 ... wad-names/ :
[quote]The IWAD filenames that source ports should recognize are:
freedoom1.wad - official name, "Freedoom: Phase 1"
freedoom2.wad - official name, "Freedoom: Phase 2"
freedm.wad - official name, "FreeDM"[/quote}

Please check also that thread:
http://www.doomworld.com/vb/freedoom/66 ... oms-iwads/

Greetings
Funduke
User avatar
funduke
 
Joined: 13 Nov 2005

Re: Please add support for the new freedoom IWAD filenames

Postby Gez » Wed Jan 15, 2014 2:13 am

freedoom1 and freedm are already recognized; all that's needed is to add freedoom2 as an alias. Also update the titles I suppose.
Gez
 
Joined: 06 Jul 2007

Re: Please add support for the new freedoom IWAD filenames

Postby Ed the Bat » Wed Jan 15, 2014 3:42 pm

Gez wrote:Also update the titles I suppose.

This would actually be simple to do on the other end (as in, Freedoom could do it themselves, without involvement of ZDoom devs) if custom titles were allowed in IWADs. I understand GAMEINFO lumps are skipped because of a risk of other problems, due to load order and such, but I often wonder if a watered-down or 'lite' alternative to GAMEINFO lumps could be offered for IWADs, specifically for non-volatile functions such as custom titlebars.
User avatar
Ed the Bat
 
Joined: 03 May 2012
Location: Maryland, US

Re: Please add support for the new freedoom IWAD filenames

Postby Gez » Wed Jan 15, 2014 3:46 pm

I think it's a missing feature more than a security measure. 1. Load GAMEINFO lumps from file list, 2. select IWAD from said GAMEINFO lumps if available or display selector box otherwise, 3. load GAMEINFO from IWAD but ignoring (of course) the IWAD key as well as any GAMEINFO key that have already been defined.
Gez
 
Joined: 06 Jul 2007

Re: Please add support for the new freedoom IWAD filenames

Postby Ed the Bat » Wed Jan 15, 2014 3:50 pm

I know IWAD GAMEINFO support has been suggested multiple times in the past, and the replies Graf gave to them made it seem like it was not going to be possible to offer these options.

viewtopic.php?f=15&t=33931
Graf Zahl wrote:It's still not a bug. The way this lump is handled it can't be used from IWADs.
User avatar
Ed the Bat
 
Joined: 03 May 2012
Location: Maryland, US

Re: Please add support for the new freedoom IWAD filenames

Postby NeuralStunner » Thu Jan 16, 2014 12:02 pm

I'm not sure why the game title at the least can't be loaded from the IWad. By the time you're seeing the title, everything (IWad, mods) is already in the loading phase.
User avatar
NeuralStunner
Registered to make one post
 
Joined: 21 Jul 2009
Location: Who?

Re: Please add support for the new freedoom IWAD filenames

Postby Xaser » Sat Jan 18, 2014 1:54 am

Ed the Bat wrote:I know IWAD GAMEINFO support has been suggested multiple times in the past, and the replies Graf gave to them made it seem like it was not going to be possible to offer these options.

Not possible? How? Doesn't the rest of the discussion make it clear that it's just a missing feature someone needs to come along and write?

To clarify something, though, the linked thread was closed but then re-opened later, which is a sign that points to feasibility.
User avatar
Xaser
secretly a supercomputer being a government
 
Joined: 20 Jul 2003
Location: .plɹoʍɹǝʌǝu.

Re: Please add support for the new freedoom IWAD filenames

Postby Graf Zahl » Sat Jan 18, 2014 5:42 am

GAMEINFO, as implemented is a pure PWAD feature. Of course this doesn't mean that some stuff from it cannot be transferred to an IWAD feature.
User avatar
Graf Zahl
 
Joined: 19 Jul 2003
Location: Germany

Re: Please add support for the new freedoom IWAD filenames

Postby fraggle » Sun Jan 19, 2014 1:47 am

If support can be added for IWADs to include a GAMEINFO lump identifying themselves then I'd be happy to add one to Freedoom.

For now we'd just like to see the IWAD files recognized as valid IWADs though.
fraggle
 
Joined: 19 Jan 2014

Re: Please add support for the new freedoom IWAD filenames

Postby Graf Zahl » Sun Jan 19, 2014 7:23 am

Could be done, of course. It would only affect the startup window's banner, though. For autodetection, ZDoom needs an entry in its IWADINFO because it's not feasible to scan all WADs it finds in the IWAD search path. Therefore, for Freedoom, which will get its IWADINFO entry anyway it makes little sense to add such a thing to the WAD itself.
User avatar
Graf Zahl
 
Joined: 19 Jul 2003
Location: Germany

Re: Please add support for the new freedoom IWAD filenames

Postby Gez » Mon Feb 17, 2014 5:42 pm

Since it was literally 10 seconds' work, have a pull request.
Gez
 
Joined: 06 Jul 2007

Re: Please add support for the new freedoom IWAD filenames

Postby funduke » Tue Feb 18, 2014 12:51 pm

Thank you!

:D

Greetings
Funduke
User avatar
funduke
 
Joined: 13 Nov 2005


Return to Closed Feature Suggestions

Who is online

Users browsing this forum: No registered users and 0 guests